codefog/contao-haste

Contao\FileUpload::getMaximumUploadSize() is static in Contao 4.6

markocupic opened this issue · 5 comments

markocupic commented

[2018-10-15 14:02:08] request.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalErrorException: "Compile Error: Cannot make static method Contao\FileUpload::getMaximumUploadSize() non static in class Haste\Util\FileUpload" at /home/sacpilat/public_html/pilot2018/vendor/codefog/contao-haste/library/Haste/Util/FileUpload.php line 5 {"exception":"[object] (Symfony\Component\Debug\Exception\FatalErrorException(code: 0): Compile Error: Cannot make static method Contao\FileUpload::getMaximumUploadSize() non static in class Haste\Util\FileUpload at /home/sacpilat/public_html/pilot2018/vendor/codefog/contao-haste/library/Haste/Util/FileUpload.php:5)"} []

ausi commented

Yes. I think we have to revert the change to the method signature from contao/core-bundle@f53e59e#diff-baa21854e252dcb04da2c161f324cf07L255

@leofeyer should I create a PR?

leofeyer commented

Yes please. 😊