coinbase/terraform-landscape

Support Terraform 0.12.x

inductor opened this issue · 18 comments

inductor commented

The latest released version doesn't seem to work well with Terraform 0.12.x

FernandoMiguel commented
  • 👍2
remipichon commented

It's true the 012 plan is much more readable but way too verbose. However Landscape is doing a great job of just output what is actually needed in most case. I have in mind the infinite "refreshing state".

  • 👍6
inductor commented

I've been using landscape as a "simpler-terraform-plan-result" tool.
as @remipichon said even on 0.12 it is still kind of annoying to see the bunch of "refreshing state" messages and would just like to see the diff from the current state.

remipichon commented

@inductor you can easily "hide" the "refreshing state" with terraform plan | grep -v "Refreshing state...". However Landscape was doing more than just hiding those logs, it was doing a great deal of just showing the actual diff and not the whole +/-/unchanged ressources attributes.

  • 👍8
nunofernandes commented

Completely agree with @remipichon . Terraform 0.12 is way verbose showing things that will remain the same with apply.

  • 👍1
inductor commented

Is this gonna happen or not? :P

sds commented

We would welcome a well-tested pull request that preserves functionality for users who are still on Terraform 0.11.x. Thanks!

neon-sombrero commented

The v0.12 plan is definitely more readable, but I would agree with @remipichon that landscape does a better job of showing the actual diffs. It would be great if it could support v0.12!

  • 👍2
servo1x commented

Landscape is still useful for diffing large blocks of text. For example when using the helm provider, you can pass in a yaml file. Landscape will pretty format it and show the relevant diff, while terraform 0.12 does not do that and that makes it difficult to see what changed.

jasonmalstrom commented

an improvement would be to add color to the entire element being created, destroy, or modified, instead of just the -/+/~

  • 👍8
sbz commented

Terraform landscape output was really great and definitively more readable with colors and diff-like output. I would love to be able to use it for Terraform 0.12.x 👍

  • 👍9
eredi93 commented

Same

james-gonzalez commented

For things like ECS task definitions where you have many tasks in a single file ? That would be a good one :)

  • 👍2
davidgereb commented

for jsonencoded maps for ECS task defs in 0.12 is not showing the changes, but the replacement of the whole json :( it'd be nice to use the tool for things like that

lewisstevens1 commented

Would like this feature also.

laxin84 commented

I, too, would love to see this.

sasq31 commented

+1

sds commented

I've locked this issue to prevent further "+1" comments that aren't helpful. Would welcome a pull request adding support for the 0.12 output syntax!