Support for 0.4.32?
orschiro opened this issue · 11 comments
Dear all,
I noticed that the plugin doesn't work anymore with 0.4.32.
Any chance we can support this version?
Thankfully,
~Robert
This is the issue that got me motivated to start closing issues. @colinking and I will try to get an update out tonight!
Dear @KyleKing,
I am very appreciative of your reaction and grateful for your support!
Thankfully,
~Robert
Ahhh brilliant. I've just downloaded N1 for this plugin alone! So glad it's not dead :D
This plugin has been mentioned in the 0.4.33 patch notes. Maybe it works again?
On a side note, will users receive any update automatically or does one have to re-download the plugin?
@orschiro Unfortunately, there is currently no built-in way to N1 to notify users that a plugin has been updated. However, the Nylas team has mentioned that they would like to improve the plugin system to add many of the features in Atom.
See:
nylas/nylas-mail#444
nylas/nylas-mail#770
I'll open an issue to bring this up with the Nylas team.
Also, this plugin should now work on 0.4.33!
Thank you @colinking!
I downloaded the latest code from master.
However, it doesn't show the icon:
The release page doesn't yet have the update, correct?
https://github.com/colinking/n1-unsubscribe/releases/tag/1.0.5
I'll open an issue to bring this up with the Nylas team.
Thank you so much! 👍
~Robert
Hmm. I couldn't recreate the problem on my system. Are there any errors on the console? (404s?) Could you verify that plugin name is correct (see #12) and that the unsubscribe image assets exist in the assets folder?
The release page doesn't yet have the update, correct?
Good call -- I'll push a new release soon.
My bad!
It was precisely #12. I downloaded master and did not change the folder name.
Thanks so much, working great. :)
~Robert
Glad to hear it's working! Thanks for the feedback + testing, Robert.