Improve code / repo
Closed this issue · 3 comments
vincentdelitz commented
- 1. Remove all .DS.store files from repo
- 2. corbado-auth-provider not necessarily needed here: https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/views/pages/login.ejs#L22
- 3. don't you need corbado-auth-provider here: https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/views/pages/profile.ejs#L22C7-L22C7
- 4. why is this file called todoService.js? https://github.com/corbado/example-webcomponent-supabase/blob/webhooks/src/services/todoService.js
- 5. Question: Do you always need a JWT when talking to Supabase? https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/services/todoService.js#L5
- 6. Remove this line: https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/controllers/authController.js#L7
- 7. Can't you merge line 10 and 14?: https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/controllers/corbadoWebhookController.js#L14
- 8. Where does this metadata need to be defined? https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/controllers/corbadoWebhookController.js#L15
- 9. Why do you work here without rpc? https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/services/userService.js#L48
nicolaistein commented
- Done
- Removed
- Yes
- Removed
- You only create a customly signed JWT if you want to act on behalf of a certain user, not e.g. for the admin api
- Dann bekomme ich einen unexpected "iss" claim value error wenn ich corbado.getCurrentUser() aufruf
- Done
- In der UserService.create() methode wird die metadata gesetzt
- If possible you do everything directly by calling the methods of the Supabase client. Rpc functions are only used if additional functionality is needed that the client doesn't provide by itself.
vincentdelitz commented
- Aber wann müssen wir denn "on behalf of a certain user" hier handeln?
- schau mal bitte nach, was deine Frontend API im Developer Panel ist (auth.corbado.com eigentlich nur noch bei alten Projekten) - bei den neuen läuft es ja über .frontendapi.corbado.io -> das sollte dann auch ohne die Zeile klappen
- Okay, aber ist es dann nicht inkosistent zu https://github.com/corbado/example-webcomponent-supabase/blob/5986460076659f9a9a47a426587fabbf24c3c6e9/src/services/userService.js#L31
nicolaistein commented
- Wenn man dann user-specific data lädt. War bei den todos der fall, aber die hab ich raus (also snippet gibts nicht mehr)
- Mit nem neuen projekt hats funktioniert, habs rausgemacht
- Alte version, im webhooks branch is es zusammengefasst