bad style: assign value to meaningful variable
Closed this issue · 1 comments
Nobody can understand what that does unless they happen to know what value the 11th position after the split holds. How to do this: assign the value to a meaningful variable and return that one.
cubi-tools/cubi-tools/update_workflow.py
Line 223 in 041731d
A meaningful variable was assigned and a description what the value is was added.
Additionally, at this point I included a check whether the API rate limit is exceeded, because if so, the error message used to be sha1SumRef.stdout.split('"')[11] IndexError: list index out of range
which is not helpful.
Also, since the same error message was shown if branch/tag and/or file-to-update wasn't in this branch/tag I included checks with meaningful error messages.