coreui/coreui-react

CRow: Additional props are not passed to underlying component

Closed this issue · 0 comments

  • Operating system and version
    • WSL 2 & Windows 11
  • Browser and version
    • Firefox Stable
  • A reduced test case or suggested fix using CodePen or JS Bin
    • Reduced test case: On a blank page, Create a CRow component with HTML-specific props, except className. e.g. onMouseOver, onDragEnter, etc. These event listeners do not function.

extra props in CRow get reduced into ...rest, which is then never used again outside of breakpoints. This is a pretty serious issue for those migrating, because it used to pass props, and pretty much every other component does pass props.

see

({ children, className, ...rest }, ref) => {
and
<div className={classNames('row', repsonsiveClassNames, className)} ref={ref}>

suggested fix:

    return (
      <div {...rest} className={classNames('row', repsonsiveClassNames, className)} ref={ref}>
        {children}
      </div>
    )

#407