Stashy does not work when using a self-signed SSL certificate for the Stash installation
Closed this issue · 5 comments
Self-signed SSL certificates are not supported by stashy but are supported by the requests library, see: http://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification.
stashy.connect() should allow verify=False (and cert as well) to be supplied to requests.
That is a great idea. I'll start putting something together.
I added support for verify=False. Let me know if this ends up working for you. Support for client certificates, proxies and timeouts are also good things to support, but I'm going to open up a separate issue for those.
There's one small addition needed before the issue can be closed. The call
chain is connect() -> Stash() -> StashClient() and the verify parameter is
needed for all three of those. I think you forgot to add it to Stash().
After the addition, things should work just fine.
On Sun, Jan 5, 2014 at 5:43 AM, Cosmin Stejerean
notifications@github.comwrote:
I added support for verify=False. Let me know if this ends up working for
you. Support for client certificates, proxies and timeouts are also good
things to support, but I'm going to open up a separate issue for those.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/3#issuecomment-31595546
.
Tomi
Well, that's embarrassing. Fixed.
Works great, thanks!