UUIDTimer uses System.currentTimeMillis()

Question

UUIDTimer uses System.currentTimeMillis()

mjburghoffer opened this issue 8 years ago · 3 comments

mjburghoffer commented 8 years ago

It would be useful if we could instead pass in an instance of a Clock so unit testing would be easier.

Answer 1 · 2016-08-15T20:57:38.000Z

Is Clock included in JDK6?

Answer 2 · 2016-08-17T18:05:52.000Z

No it is not.

Answer 3 · 2016-08-17T21:11:52.000Z

My main concern is just that JUG only requires JDK6. Looks like Clock was added for Java 8.
Otherwise I don't have objections (esp. for adding convenience alternatives). Maybe it'd be possible to add a non-JDK interface of clock object to pass instead if the goal is unit testing. PRs welcome.