cp2004/OctoPrint-WLED

[Bug] Previous intensity values not honored when editing the config.

samwiseg0 opened this issue · 4 comments

Description of the bug

When editing printing effects. If you change the intensity, the changes do not persist if you load the config again or make any other changes after saving. This also changes any other effects that contained modified intensities back to 127.

Steps to reproduce

  1. Open the config modal.
  2. Edit a printing effect
  3. Change the intensity
  4. Save
  5. Attempt to edit the config again
  6. Note that the intensity is back to default of 127.

What did you expect to happen

The intensity config to persist.

Logs and screenshots

Does the plugin have its own logging? I did not see a specific log file for WLED?

Screen Shot 2021-06-11 at 4 31 10 PM

Version of plugin and OctoPrint

Octorpint: 1.6.1
Plugin 0.2.0

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.128 Safari/537.36

Additional context

N/A

Try 0.2.1rc1 from the pre-release channel. Not entirely sure if I've done it right since tagging the right branch was hard, hopefully some git magic has sorted it.

Does the plugin have its own logging? I did not see a specific log file for WLED?

There's no specific log, everything for this plugin is logged to the octoprint.log. And there can be quite a lot of detail/granular control as well (if you
wanted it) using the debug logging settings:
image

For some reason it is still not available? I told it to check for updates but it returns everything is up to date
Screen Shot 2021-06-11 at 6 55 40 PM

There's no specific log, everything for this plugin is logged to the octoprint.log. And there can be quite a lot of detail/granular control as well (if you

Ah ok I was not sure. Thanks

I updated manually. Its fixed! Thanks!

The manual install should work:

https://github.com/cp2004/OctoPrint-WLED/releases/download/0.2.1rc1/release.zip

The tag was initially created from the wrong branch, so I moved it across but I think I've confused GitHub so OctoPrint is not picking it up...