cp2004/OctoPrint-WLED

[Feature Request] Main brightness setting

ipa64 opened this issue · 2 comments

ipa64 commented

Is your feature request related to a problem? Please describe.
No

Could be more useful to have a main brightness setting, that will be applied to all effects unless they have an own defined brightness value (not undef). It could be located in the Node settings (actual name is Connection settings) . In the same time, don't you think {Overrides on/off} setting should be located in Node settings too ? In fact I don't see any raison to have it in effects settings, but maybe I am missing something.
Thank you

Why should this be implemented?
I think the most of case, the brightness value is the same for all effects, so if you want to adjust brightness you need to edit all 10 effects.

Additional context

I think that could work, I suppose this would be easier if you want to increase or decrease brightness for all the effects - it could get quite tedious otherwise.

In the same time, don't you think {Overrides on/off} setting should be located in Node settings too ? In fact I don't see any raison to have it in effects settings, but maybe I am missing something.

This setting means that (if it is enabled) when the effect runs, then it will turn the lights on to show the effect. This has to be per-effect, but it doesn't have to be per-segment.

ipa64 commented

I suppose this would be easier if you want to increase or decrease brightness for all the effects.

Exacltly

This setting means that (if it is enabled) when the effect runs, then it will turn the lights on to show the effect. This has to be per-effect, but it doesn't have to be per-segment.

In fact I don't understand why a effect should not power on lights ?