crashinvaders/gdx-vfx

Crash on iOS

Snehks opened this issue · 8 comments

Snehks commented

Hi, I am getting the following crash on iOS.

com.badlogic.gdx.utils.GdxRuntimeException: File not found: gdxvfx/shaders/screenspace.vert (Classpath)
 	at com.badlogic.gdx.files.FileHandle.read(FileHandle.java:142)
 	at com.badlogic.gdx.files.FileHandle.length(FileHandle.java:638)
 	at com.badlogic.gdx.files.FileHandle.estimateLength(FileHandle.java:239)
 	at com.badlogic.gdx.files.FileHandle.readString(FileHandle.java:204)
 	at com.badlogic.gdx.files.FileHandle.readString(FileHandle.java:197)
 	at com.crashinvaders.vfx.gl.VfxGLUtils.compileShader(VfxGLUtils.java:103)
 	at com.crashinvaders.vfx.gl.VfxGLUtils.compileShader(VfxGLUtils.java:79)
 	at com.crashinvaders.vfx.effects.LensFlareEffect.<init>(LensFlareEffect.java:61)

The project works fine on desktop and Android.

metaphore commented

Hi @Snehks,
Thanks for the report.
Sorry for the delay, but I do not actively maintain this project atm.
I will check on the issue next week and hopefully prepare a new release for LibGDX 1.10.0

Laurent1967 commented

Hi, I get this error too. Have you already found some time to look at this ?
Thanks !

Laurent1967 commented

This issue is still there after the update to libGDX 1.10.0

metaphore commented

Hi, sorry for not coming back to you earlier on this one.
The problem was identified a while ago and still didn't get any resolution.

The issue here is with the specifics of MobiVM. iOS modules basically don't pick up the library's built in asset files (including those shader vert/frag ones).

While there's technically still no easy fix, one workaround would be to extract the library's assets and add them to iOS module manually. For that you'd need to

  1. Grab the entire gdx-vfx/effects/assets dir and place it to the root of your iOS submodule.
  2. In your robovm.xml file add a resource configuration entry like so
<config>
  ...
  <resources>
    <resource>
      <directory>assets</directory>
      <includes>
        <include>**</include>
      </includes>
      <skipPngCrush>true</skipPngCrush>
    </resource>
    ...
  </resources>

That should do the trick. Please let me know if you have any issues with that.

  • 👍1
Laurent1967 commented
lucas-kakele commented

Hey @metaphore, thanks for providing an workaround.

If I understood this correctly, the vert/frag files are read using Gdx.files.classpath, for example here:

gdx-vfx/gdx-vfx/effects/src/com/crashinvaders/vfx/effects/util/CopyEffect.java

Line 33 in 3de10cf

Gdx.files.classpath("gdxvfx/shaders/screenspace.vert"),

I tested the workaround and I believe it doesn't work because when the FileHandle tries to read it, it loads from the classpath here.

Do you have any suggestions on alternatives? (maybe using Gdx.files.internal given it will try both the internal and classpath types?)

Cheers!

metaphore commented

Unfortunately, the MobiVM team hasn't provided any helpful insight as of yet and I don't really have any good workaround for the vfx-effects module.

The only thing that can be done now, is to grab the effects code, replace all the classpath file references with internal. That requires having all the vert and frag shader files to be manually added to your game's assets...

lucas-kakele commented

Thanks!

I copied the code for the time being, replacing the references.

Note for future readers: you have to do it to iOS only. For Android, still use the classpath call. I didn't test for other platforms but I believe it is a good idea keep using classpath.

Cheers!