Merge with master?
Closed this issue · 5 comments
I've noticed the last commit is from 2017, and there's a few experimental changes from 2018 in the formats branch
If people are interested, I've merged opensles fork with master from Feb 2021 (that's what I've been using). I can submit a PR if there's interest.
I'm still testing and so far so good.
Ah neat! It's been a while indeed since I've worked on this.
Looking quickly at the rebase branch, I think it'd move the readme changes to the hostapi/opensles readme, I only added them in the main readme so it would be visible on github. Since portaudio is on GH now I think it might actually be worth trying to get this fork merged. I'm also happy to rebase it myself, it looks like a relatively painless one.
I'll take a look at/test #9 tomorrow.
PR submitted!
I'm also happy to rebase it myself, it looks like a relatively painless one.
Looking at the size of the PR, it looks like perhaps a rebase may be a better approach than a merge.
yea I'll just rebase it; and i might push it to a different branch from master right now. This was originally developed for https://github.com/exporl/apex/ and I want to give them a headsup. Which is why I also made the v1 tag.
Included your fix in the v1 tag, I'll rebase the whole thing tomorrow, get the formats branch in depending on the work remaining and see if portaudio is interested in this fork.
Done in the https://github.com/Gundersanne/portaudio_opensles/tree/opensles-pr-candidate branch; I need to test this some more and not entirely sure yet about all the commits in that branch, but it's rebased.