cucumber/cucumber-ruby-core

Rake task exiting with 0 on failure

Closed this issue · 5 comments

mattwynne commented

The build is failing on JRuby, but passing on the other Rubies despite having two failing specs.

It seems that the rake task exits with 0 even when there are scenarios failing. @tooky can you take a look at this?

kgrz commented

Tried to make a test fail on the master branch and the task rake spec returns correct exit codes. 1 when there is a failure and 0 when all tests pass.

mattwynne commented

Thanks for looking into it @kgrz. I may have diagnosed the problem incorrectly, but here is an example of the symptom. Note that Travis thinks this build is OK, even though tests failed.

tooky commented

@mattwynne I haven't looked at the example, this was happening a little
while ago and I fixed it, I thought. Not at a computer right now so can't
investigate.

This was the fix I added 123f279
On 31 Dec 2013 09:32, "Matt Wynne" notifications@github.com wrote:

Thanks for looking into it @kgrz https://github.com/kgrz. I may have
diagnosed the problem incorrectly, but here is an example of the symptomhttps://travis-ci.org/cucumber/cucumber-ruby-core/jobs/15319456.
Note that Travis thinks this build is OK, even though tests failed.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/40#issuecomment-31388929
.

tooky commented

Fixed by e66f3b7

lock commented

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.