cvdlab/react-planner

Feature: Export to Mesh

JaccoGoris opened this issue · 5 comments

I see that there is already a closed issue for this (#55 ) butI can't seem to figure out how to export the meshes.
I feel that there is value in this, and I need this myself, so I want to add an exporter on my own fork (if that's not already there, can't find it :D).
Do you see value in a PR once I'm finished?
And do I add this as a Plugin or should I add it as an action?

Hi @JaccoGoris.
I think #55 regarded the save project button and so it was not related to the 3D scene.
Exporting 3D scene is a bit messy as the scene generation process is completely asynchronous (so we should wait for the entire scene to be loaded before we can download it).
I would love to see this exporter as a plugin but in order to do this we should export the scene creator (and I don't like the idea...) so the simpler choice should be to add it as an action

P.s. I would like a PR 😉 as I do not have much time to dedicate on it

Alright! I got the Export to work and I'm now figuring out the action system to add it as a button in the toolbar. There are some issues, mostly in the back and front faces. I turned them off in the wall-factory for now but that's not a long term solution of course.

The other issue is that sometimes the wall and doors are not spawned correctly in the 3D scene and the exporter fails :D

I also had to update three to the latest version.

I'll make a PR as soon as I'm done :)

@danilosalvati Made a PR for this, let me know if something is missing / you'd like to see differently

I will have a look on it soon