"web" service generates with probes, but installs without probes
TBBle opened this issue · 1 comments
The notes say that web should be installed with helm_upgrade_probe_yes_prometheus_no, and the YAML for the service appears to agree, as of cyber-dojo/web@9ac1ed6
However, the install script uses helm_upgrade_probe_no_prometheus_no and hence the install fails, because there is a liveness probe path, but not a port:
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: [ValidationError(DaemonSet.spec.template.spec.containers[0].livenessProbe.httpGet): missing required field "port" in io.k8s.api.core.v1.HTTPGetAction, ValidationError(DaemonSet.spec.template.spec.containers[0].readinessProbe.httpGet): missing required field "port" in io.k8s.api.core.v1.HTTPGetAction]
Tested against a 1.18.9 on-prem k8s cluster.
Changing the install script to use helm_upgrade_probe_yes_prometheus_no seems to have allowed the install to complete, although it's not yet working, I'm still looking into that.
Hi Paul,
first of all, thanks for this and your other reports.
I know very very little about k8s, helm, etc I'm afraid.
We need is a single place that defines what function (eg helm_upgrade_probe_no_prometheus_no) to use in both places.
I'm hoping that the person who does most of the work on this repo, and knows about this problem, will get round to it soon. But it depends on how much real work they have of course.
Thanks again
Jon