Cannot `fundle update`

Question

Cannot `fundle update`

hauleth opened this issue 9 years ago · 10 comments

Output message:

fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
Updating hauleth/agnoster
Updating fishery/rbenv
Updating fishery/z

Answer 1 · 2016-06-17T10:43:11.000Z

Hi, thanks for reporting.

For some reason, the .git directory seems to be missing from some of your plugins.
Just to be sure, could you paste the output of

find ~/.config/fish/fundle/ -maxdepth 3 -type d

please?

Answer 2 · 2016-06-17T10:46:07.000Z

/Users/hauleth/.config/fish/fundle/
/Users/hauleth/.config/fish/fundle//fishery
/Users/hauleth/.config/fish/fundle//fishery/rbenv
/Users/hauleth/.config/fish/fundle//fishery/rbenv/.git
/Users/hauleth/.config/fish/fundle//fishery/rbenv/completions
/Users/hauleth/.config/fish/fundle//fishery/rbenv/conf.d
/Users/hauleth/.config/fish/fundle//fishery/rbenv/functions
/Users/hauleth/.config/fish/fundle//fishery/z
/Users/hauleth/.config/fish/fundle//fishery/z/.git
/Users/hauleth/.config/fish/fundle//fishery/z/conf.d
/Users/hauleth/.config/fish/fundle//fishery/z/functions
/Users/hauleth/.config/fish/fundle//fishery/z/man
/Users/hauleth/.config/fish/fundle//fishery/z/test
/Users/hauleth/.config/fish/fundle//hauleth
/Users/hauleth/.config/fish/fundle//hauleth/agnoster
/Users/hauleth/.config/fish/fundle//hauleth/agnoster/.git
/Users/hauleth/.config/fish/fundle//hauleth/agnoster/agnoster
/Users/hauleth/.config/fish/fundle//hauleth/agnoster/screenshots

It seems ok, it looks like fundle do not provide proper GIT_DIR when updating.

Answer 3 · 2016-06-17T10:48:44.000Z

I think that you should also provide GIT_WORK_TREE variable while updating.

Answer 4 · 2016-06-17T10:49:27.000Z

Yeah, this seems to be fine.

I am setting git-dir through the --git-dir option, could it be that it gets overriden by an env variable?

I am passing the work-tree during the call to checkout, which should be enough.
Any other place you think it should be present?

Answer 5 · 2016-06-17T10:56:08.000Z

Ok, I have found the issue. I have overrided git with hub which do not pass --git-dir command to the origin git. You should use command git instead of bare git to be sure that origin git was ran. I will fill issue against hub also.

Answer 6 · 2016-06-17T10:58:03.000Z

@hauleth Thank you for investigating!
I will change to command git to be safe, just a moment 😄

Answer 7 · 2016-06-17T11:07:39.000Z

I fixed it and updated to 0.5.2, could you run fundle self-update and tell me if it works please? 😄

Answer 8 · 2016-06-17T11:15:39.000Z

You forgot to push tag ;)

Answer 9 · 2016-06-17T11:22:19.000Z

Woops 😓
Here you go! 🎉

Answer 10 · 2016-06-17T11:36:14.000Z

Works, thanks.

Wiadomość napisana przez Daniel Perez notifications@github.com w dniu 17.06.2016, o godz. 13:22:

Woops 😓
Here you go! 🎉

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #24 (comment), or mute the thread https://github.com/notifications/unsubscribe/AARzN505qYTdNyWLb6P3Rwm7iaV6gBz9ks5qMoNsgaJpZM4I4PJ0.