issues rolling into google3 (from the sdk)
Closed this issue · 5 comments
devoncarew commented
I'm seeing issues rolling the recent ~6 commits into google3:
.../dartdoc/bin/main.dart:15:24: Error: The argument type 'PackageMeta? Function(LibraryElement, String?, ResourceProvider)' can't be assigned to the parameter type 'PackageMeta? Function(LibraryElement2, String, ResourceProvider)'.
- 'PackageMeta' is from 'package:dartdoc/src/package_meta.dart' ('.../dart/dartdoc/lib/src/package_meta.dart').
- 'LibraryElement' is from 'package:analyzer/dart/element/element.dart' ('.../dart/analyzer/lib/dart/element/element.dart').
- 'ResourceProvider' is from 'package:analyzer/file_system/file_system.dart' ('.../dart/analyzer/lib/file_system/file_system.dart').
- 'LibraryElement2' is from 'package:analyzer/dart/element/element2.dart' ('.../dart/analyzer/lib/dart/element/element2.dart').
Google3PackageMeta.fromElement,
^
ERROR: dart/dartdoc/bin/main.dart:15
The argument type 'PackageMeta? Function(LibraryElement, String?, ResourceProvider)' can't be assigned to the parameter type 'PackageMeta? Function(LibraryElement2, String, ResourceProvider)'. #argument_type_not_assignable
Google3PackageMeta.fromElement,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
srawlins commented
That roll will require a patch at dart/dartdoc/bin/main.dart:15.
pq commented
Is this issue resolved?
devoncarew commented
I don't believe so - I have not rolled it in since filing this.
srawlins commented
I'm looking at this now.
srawlins commented