v8 compilation fixes for f16 (gcc 4.6.1)

Question

v8 compilation fixes for f16 (gcc 4.6.1)

DartBot opened this issue 14 years ago · 9 comments

This issue was originally filed by bobbypow...@gmail.com

What steps will reproduce the problem?
1.try building on fedora 16
2.
3.

What is the expected output? What do you see instead?
A completed build of v8, instead it stops compilation at multiple spots because gcc is told to treat all warnings as errors.

What version of the product are you using? On what operating system?
latest dart, f16 x64

Please provide any additional information below.

Attachment:
dart_f16.diff (2.37 KB)

Answer 1 · 2011-10-10T23:07:31.000Z

This comment was originally written by bobbyp...@gmail.com

let me know the best way to report/submit patches. I'm not really familiar with the gclient/depot_tools stuff yet.

Answer 2 · 2011-10-11T02:56:56.000Z

This comment was originally written by Ray.R...@gmail.com

Same configuration as original reporter. I used a used an all.deps build and hit a couple more similar but very minor warnings that were easily correctable. All hit the java private/protected issue #10. all.deps built OK for ia32 build.

Linux ray.localdomain 2.6.40.6-0.fc15.x86_64
gcc version 4.6.1 20110908 (Red Hat 4.6.1-9) (GCC)

[ray@ray dart]$ ./out/Debug_ia32/dart ~/hello.dart
Hello, World!

Answer 3 · 2011-10-11T13:49:50.000Z

This comment was originally written by bobbypowers...@gmail.com

Ray: The other compilation fixes that I needed (that I imagine you did yourself) are over at http://code.google.com/p/dart/issues/detail?id=57 . I was in the process of posting them last night, but google code crashed/made itself unavailable.

Answer 4 · 2011-10-11T14:06:28.000Z

This comment was originally written by drfibonacci@google.com

Set owner to @iposva-google.
Added OpSys-Linux, Accepted labels.

Answer 5 · 2011-10-11T14:08:19.000Z

This comment was originally written by drfibonacci@google.com

Issue #57 has been merged into this issue.

Answer 6 · 2011-10-11T14:10:18.000Z

This comment was originally written by drfibonacci@google.com

Set owner to @dgrove.

Answer 7 · 2011-10-11T15:50:22.000Z

Please file V8 compilation bugs with the V8 project: http://code.google.com/p/v8/issues/list

Added Invalid label.

Answer 8 · 2011-10-11T16:18:28.000Z

This comment was originally written by bobbypo...@gmail.com

okay, but issue #57 was compilation fixes for dart-runtime, not v8. Those aren't invalid

Attachment:
runtime_f16.diff (1.70 KB)

Answer 9 · 2011-10-11T17:01:21.000Z

Issue #9 has been merged into this issue.