mm9 failing
Closed this issue · 6 comments
Combining...
I don't have data for reference assembly mm9
We have LOLA resources for mm9 but because GenomicDistributions lacks this so far, I realized it's causing the whole thing to fail.
@vpnagraj can you make it so the genomic distribution plots are not catastrophic if they fail? So it can still show the LOLA results?
databio/GenomicDistributions#2
I will work on adding mm9 to GD but in this is generally useful that it should show whatever it can without failing catastrophically.
@nsheff i pushed a commit last night (87115bd) that i believe addresses this:
http://dev.lolaweb.databio.org/?key=5WDJEXFLG7TIR91
basically skips the genomic distributions processing if the genome isn't in utils::data(package="GenomicDistributions")$results[,"Item"] for TSS, chromeSize, geneModels respectively ... if any or all of those are present, then the data is processed accordingly and plot(s) will appear
if this looks good to you, i'll pull onto production ASAP as a bug fix
I just released v0.5 of Genomic Distributions, which includes mm9 data.
basically skips the genomic distributions processing if the genome isn't in utils::data(package="GenomicDistributions")$results[,"Item"] for TSS, chromeSize, geneModels respectively ... if any or all of those are present, then the data is processed accordingly and plot(s) will appear
Now that I think about this, a better approach would be to just wrap this processing in a tryCatch, because the current method relies on the way GenomicDistributions is internally doing things, which is not guaranteed. No need to peer into that package's inner workings, just make it so if those tasks fail, they fail gracefully by just not printing failed plots. This method is easier to implement, easier to maintain, and more robust to changes in the other package.
did we ever pull 0.5 of GenomicDistributions into this? Because my mm9 run is still not displaying those plots...
(it is not failing, which means the above fix succeeded).