Releasing a new version?

Question

Releasing a new version?

Closed this issue 8 months ago · 7 comments

krassowski commented 9 months ago

Hi, would it be a good time to release a new pre-release? I can run the actions if that's ok.

Also, do you plan further developments on this repo?

Answer 1 · 2025-02-27T23:30:20.000Z

Just checking back @echarles, is it ok for me to go ahead and cut a pre-release?

Answer 2 · 2025-02-28T02:54:19.000Z

@krassowski Sure, please cut a release if it works for you

Answer 3 · 2025-02-28T08:04:13.000Z

Thank you! It turns out while I can run the action, I cannot release:

Getting permission level for krassowski
User krassowski does not have admin permission

Do you plan to continue developing this extension?

Answer 4 · 2025-02-28T08:35:41.000Z

I have given you temporary admin role.
Yes, we are working on this extension.

Answer 5 · 2025-02-28T10:05:27.000Z

Hmm.. It looks like Step 2 failed:

***github.com/datalayer/jupyter-server-nbmodel.git
remote: error: GH013: Repository rule violations found for refs/heads/main.
remote: Review all repository rules at https://github.com/datalayer/jupyter-server-nbmodel/rules?ref=refs%2Fheads%2Fmain
remote:
remote: - Changes must be made through a pull request.
remote:
To https://github.com/datalayer/jupyter-server-nbmodel.git
 * [new tag]         v0.1.1a2 -> v0.1.1a2
 ! [remote rejected] HEAD -> main (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/datalayer/jupyter-server-nbmodel.git'
Traceback (most recent call last):

https://github.com/datalayer/jupyter-server-nbmodel/actions/runs/13585412125/job/37979163725

Answer 6 · 2025-02-28T10:28:11.000Z

Ah, I see there were two sets of branch protection rules, one defined via Rules (with bypass for Releaser):

and one via Branches (which does NOT support bypass):

GitHub UI is super confusing here. I fixed it by removing the duplicate "Require a pull request before merging" from Branch-level rule while keeping both rules (though personally I don't think both are needed).

https://github.com/datalayer/jupyter-server-nbmodel/releases/tag/v0.1.1a2 is out on PyPI (https://pypi.org/project/jupyter-server-nbmodel/) you can now donwngrade my rights - thank you!

Answer 7 · 2025-02-28T10:31:07.000Z

GitHub UI is super confusing here

I think this is because they first implemented branch protection rules and found them insufficient and then added rulesets as a more flexible feature. So now every now and then we find conflicting config in various repos because the UI for these two is disjoint. This kind of supports my intuition: https://stackoverflow.com/questions/79292201/what-are-the-practical-differences-between-github-rulesets-and-branch-protection