davidavdav/NamedArrays.jl

Allow any AbstractArray for names in constructor

Closed this issue · 1 comments

nalimilan commented

Do you think it would be possible to change this line to accept any AbstractArray? That would be useful in FreqTables to allow passing a CategoricalArray. Currently this makes our tests fail.

NamedArrays.jl/src/constructors.jl

Line 54 in e3bbb1a

names::Vector{VT}=[defaultnames(d) for d in size(array)],

nalimilan commented

Thanks! Actually it turned out more methods need the same change. I've filed #85.