davidfig/pixi-viewport

Will it support V8 version?

Closed this issue · 7 comments

Will it support V8 version?

I think some work is ongoing here
#468

I made quick update on-top of #468 to use Pixi v8.0.4 and it seems to work well on my project.

My forked version:
https://github.com/WillYuum/pixi-viewport

I'm not sure if I should contribute to the repo in the 468 or just make a pull request directly on main pixi-viewport.
So made a pull request here:
#483

@davidfig would you mind checking out @WillYuum's PR? This is blocking our upgrade to pixi v8. Thank you!

I made quick update on-top of #468 to use Pixi v8.0.4 and it seems to work well on my project.

My forked version: https://github.com/WillYuum/pixi-viewport

I'm not sure if I should contribute to the repo in the 468 or just make a pull request directly on main pixi-viewport. So made a pull request here: #483

Thanks, for me your fork works great with 8.1.0. @davidfig please, consider merging this to the main

anynone got it working with this line? @VitalyEmelyanov @matthewgapp

app.stage.addChild(viewport)

// Argument of type 'Viewport' is not assignable to parameter of type 'Container'.
//  Type 'Viewport' is missing the following properties from type 'Container': uid, _updateFlags, isRenderGroupRoot, 
// renderGroup, and 101 more.ts(2345)

I am on typescript.

full code looks like this

const app = new Application()
  await app.init({ width: 1080, height: 1080, backgroundColor: 0xffffff })
  document.body.appendChild(app.canvas)

  const viewport = new Viewport({
    screenHeight: window.innerHeight,
    screenWidth: window.innerWidth,
    worldHeight: 1024,
    worldWidth: 1024,
    passiveWheel: false,
    
  })

  app.stage.addChild(viewport)

it would be also super nice if viewport can support V8 renderGroup feature. Would give out of the box performance boost.

Anyone having issues, check #487