[BUG] Polyphone determines sf3 soundfonts via the filename, not the soundfont version
Closed this issue · 1 comments
spessasus commented
The issue
Polyphone decompresses the soundfont only if the filename extension is sf3. It doesn't check ifil
like it should. (Or check sample type). This causes soundfont3 soundfonts saved with a .sf2 extension to be broken.
How to reproduce
- Grab this sf2 file and open it
- Navigate to samples
- Audio is completely broken
- Rename extension to "sf3"
- Reopen and navigate to samples
- Audio is fixed
Expected behavior
Polyphone should check if ifil
is 3 instead of filename extension. That or check if (sampleType & 0x10) > 1
Version tested
2.3.1 (Flatpak)