Inserting iframes in new widget?

[gnestor]

I understand that each kernel is sandboxed to its own iframe, but do these iframes need to create a new widget? Could they be inserted in lab's body with 0x0 dimensions?

[bollwyvl]

They don't _need_ to show an element, but that's where you can actually draw stuff, as you don't get a handle on the original parent cell Dom (in preparation for the eventual less-unsafe webworker-backed kernels that I'll get to at some point). I like the direct manipulation aspect of the iframe however, as you when close it, the kernel is GONE. I also tried putting them in the output of the first cell, such that you could choose to put it in it's own cloned output, but that gets... Complicated. Perhaps the right thing is to still always create an iframeMainWidget, but don't attach it, or hide it. Then in user code, have a magic that can show the widget, and/or a notebook toolbar button that can also show it.

…

On Thu, Apr 4, 2019, 00:54 Grant Nestor ***@***.***> wrote: I understand that each kernel is sandboxed to its own iframe, but do these iframes need to create a new widget? Could they be inserted in lab's body with 0x0 dimensions? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#41>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACxRCJycIveZobhm6rQ9SvnwSSh5wTLks5vdYVpgaJpZM4cb7fD> .

[gnestor]

Ok, I understand. Ideally, we want these kernels to behave like other kernels in that the output of cell x is rendered in the output area of cell x.

This could work by creating an iframe element just for sandboxing purposes and then running all input code using eval and then rendering the result of that in the output. The iframe in this case wouldn't be attached or appended to a widget.

If the result of evaluating the input is an HTMLElement, then we append it to the output area. If it's a ReactElement, we ReactDOM.render it in there. We can handle those type of known cases and then render everything else as a string.

I like being able to restart a jyve kernel, but the way to do that should be consistent with how it's done with other kernels ((e.g. "Restart kernel").

I'm willing to help with this stuff, just wanna hash out out first. I really want a legit JS and Pyodide kernel 👍