selectCollection don't return error
lATAl opened this issue · 4 comments
If an error occurs after fetch collections, selectCollection don't return error object.
Hi thanks for posting an issue!
Could you send me some sample code and data to help me replicate the issue?
In particular, what error did your api return (an http status code?), what
is the (incorrect) output of selectCollection, and what is the output you
were expecting to get from selectCollection?
That'll help me fix the issue. Thanks!
On Tue, Jul 19, 2016, 5:19 PM Lê Anh Tuấn notifications@github.com wrote:
If an error occurs after fetch collections, selectCollection don't return
error object.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#18, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABVELAnp_pzCKTAMeB1pJCZ9HK6Yl0Htks5qXJaJgaJpZM4JPh56
.
I've reviewed the code and I think I see what you mean - if there is a FETCH_ERROR, selectCollection doesn't give you any indication of that. This is why it's great to have more people using this! We just haven't run into a collection fetch error yet so we never noticed.
I'll make a pull request and send you a message - would you be interested in reviewing the code and testing it?
OK 4.2.1 is published with this change! Thanks!
👍