FakePagerDutyEventsClient - Status returned doesn't match PagerDuty API

[anjo-swe]

From what i can tell PagerDuty Events API V2 will always return success if everything was ok.

When using FakePagerDutyEventsClient in a test i instead received success-trigger.

pagerduty-client/src/main/java/com/github/dikhan/pagerduty/client/events/utils/FakePagerDutyEventsClient.java

Line 95 in 2a3efcb

return EventResult.successEvent("success-" + incident.getEventAction().getEventType(), "Event processed", incident.getDedupKey());

Can this be changed to match PagerDuty API?

Regards,
Andreas

[dikhan]

Hi Andreas, Makes sense, please feel free to submit a PR with the change. Thanks, Dani

…

On Tue, Oct 17, 2017 at 1:44 PM, Andreas Jonsson ***@***.***> wrote: From what i can tell PagerDuty Events API V2 will always return success if everything was ok. When using FakePagerDutyEventsClient in a test i instead received success-trigger. https://github.com/dikhan/pagerduty-client/blob/ 2a3efcb/src/main/java/com/ github/dikhan/pagerduty/client/events/utils/FakePagerDutyEventsClient. java#L95 Can this be changed to match PagerDuty API? Regards, Andreas — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbvgjaUJ1PHEBx2f4Q1Ur1F2rgw3VIYks5stRHHgaJpZM4P8y1W> .

-- Daniel I. Khan di.khan.r@gmail.com

[anjo-swe]

PR created (#10), let me know what you think