Make public methods in SimpleApp and KVWorker, KVServer virtual to enable testing.
shilad opened this issue · 2 comments
shilad commented
I'd like to write tests for components that rely on SimpleApp, KVWorker, and KVServer. The easiest approach to do this is fake or mock SimpleApp, etc., but this is difficult now because the public methods are non-virtual.
Does it seem reasonable to make these virtual?
mli commented
no problem for me
shilad commented
Great! I'll send a PR then.
Sent from my phone. Please excuse abbreviations and fat fingers.
On Apr 8, 2016, at 12:21 PM, Mu Li notifications@github.com wrote:
no problem for me
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub