doowb/ansi-colors

What were the breaking changes, if any, in v4?

MatthewHerbst opened this issue · 2 comments

MatthewHerbst commented

There is no CHANGELOG/HISTORY file, and the releases have no information. A major semver version change implies there were breaking changes. Could you please let us know what those were? Thank you

jonschlinkert commented

A major semver version change implies there were breaking changes

No it doesn't. When there are breaking changes, a major version bump should be used, but a major version bump may be used for other reasons.

Could you please let us know what those were?

If there were, we would.

MatthewHerbst commented

@jonschlinkert from the semver spec used by npm:

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes,
  2. MINOR version when you add functionality in a backwards compatible manner, and
  3. PATCH version when you make backwards compatible bug fixes.

Further in the spec:

Major version X (X.y.z | X > 0) MUST be incremented if any backwards incompatible changes are introduced to the public API. It MAY also include minor and patch level changes. Patch and minor version MUST be reset to 0 when major version is incremented.

Anyways, you're going to confuse the heck out of lots of people, and waste your time and others (as this issue has shown) by not documenting changes (or the lack thereof) when changing the major version.

Thanks for helping maintain this otherwise excellent package!

  • 👍2