Expanding snippets inside snippets deletes tabstops

Question

Expanding snippets inside snippets deletes tabstops

Opened this issue a year ago · 77 comments

Possibly very related to #157.

When expanding a snippet inside another snippet, all tabstops of the former snippet are deleted. An example:

snippet OOO "Omega" iA
\Omega
endsnippet

snippet II "\int" i
\\int_{$1}${2:f}~d${3:\\mu}
endsnippet

If I write "OOO" inside tabstop $1 of "\int", the snipet "Omega" is expanded correctly, but the tabstops $2 and $3 of "\int" disappear.

This doesn't happen with "native" vscode snippets.

Answer 1 · 2024-02-07T15:45:48.000Z

Additional note, downgrading VS Code to the December 2023 version fixed this bug for me.

Answer 2 · 2024-02-16T07:41:09.000Z

I am having the same issue, but downgrading did fix it for me.

Answer 3 · 2024-02-23T15:25:55.000Z

Anyone find another fix to this? I am using linux (arch) and have a hard time downgrading as I got vscode from the AUR

Answer 4 · 2024-03-07T01:38:28.000Z

Any update? I originally downgraded to December 2023 but thought I'd retry and this is still an issue. I haven't been able to figure out what part of the VSCode update affected this to think of a workaround. Any ideas for what it may be?

Answer 5 · 2024-03-07T09:20:29.000Z

Nothing new. Still does not work. Have you @gwesley96 tried any other versions later than the December one? Would be ideal to see which exact version causes issues.

Answer 6 · 2024-03-07T13:50:49.000Z

@Oskar-Idland, do you mean the commit or the release? I can try and figure out the latter.

Answer 7 · 2024-03-07T15:13:40.000Z

Yes i meant the latest vscode release where expansions works as intended. Hopefully it helps resolve the issue to narrow it down

Answer 8 · 2024-03-07T16:11:27.000Z

Ok, tabstops still work in 1.85.2 but not 1.86.0.

Answer 9 · 2024-03-08T15:46:08.000Z

I tried seeing the difference on the 1.86 commit, but could not see anything that made sense. Anyone able to try and debug this?

Answer 10 · 2024-03-12T09:44:17.000Z

Same issue here

Answer 11 · 2024-03-14T17:35:51.000Z

Experimented more in v.1.87.2 and found the following:

LaTeX Utilities's snippets and the ones built into vscode still works while nested. Only hsnips fails.
I also noticed that you must have the hsnips by OrangeX4 (https://github.com/OrangeX4/hsnips) to be able to open the snippet directory or files or be able to activate any snippets at all. If I only had draivin's (this) version of hsnips I could not even open the snippet file as I got the following error:

Answer 12 · 2024-03-25T01:49:49.000Z

I'm still coming up with nothing. I've looked through all the details and couldn't find anything that on the surface would affect hsnips/tabstops. Has anyone else found anything yet?

Answer 13 · 2024-04-01T13:03:03.000Z

Anyone know the maintainers (@draivin @mfederczuk) of the extension is on it?

Answer 14 · 2024-04-01T13:05:46.000Z

Anyone know the maintainers (@draivin @mfederczuk) of the extension is on it?

Just FYI I'm not a maintainer here.
I've only contributed some code once.

Answer 15 · 2024-04-05T09:42:34.000Z

For any Arch Linux users reading this, just download the tar ball from 1.85 (other distros has their versions there as well), extract to some directory of choice (I chose ~/VSCode_Old), then just make a symlink from /usr/bin/code to the executable at VSCode-linux-x64/bin/code where ever you extracted it. I renamed the newest binary to code_new just to have it somewhere:

[oskar@archlinux] /usr/bin $ lsd -1 | grep ^code
code ⇒ /home/oskar/VSCode_Old/VSCode-linux-x64/bin/code
code_new

Everything else (settings, snippets etc) remained the same.

Answer 16 · 2024-04-17T10:44:29.000Z

Is anybody able to make the above solution work for MacOS?

Answer 17 · 2024-04-17T11:04:28.000Z

If you press the link I posted above, you will see the download link for Mac as well as Windows and Linux. This is much simpler for you guys

Answer 18 · 2024-04-17T11:07:50.000Z

Oh okay, it sounds like you merely downgraded your Visual Studio Code (I guess your point of the comment was to make it work for linux). Yes, that's what I have been doing for the time being.

Answer 19 · 2024-04-17T12:50:39.000Z

Hope this gets fixed. Can't use the python extension (and probably many others) on lower than v1.86

Answer 20 · 2024-05-06T13:03:17.000Z

Anyone have actual knowledge about the project and it's structure or Typescript? I have neither, but know programming and would love to help sort this out, but it is hard to tell what is wrong, without knowledge of the project

Answer 21 · 2024-06-03T11:03:28.000Z

Could it be possible that this is a vscode issue and raising the issue there would get it fixed or maybe some pointers towards solving the issue?

Answer 22 · 2024-06-04T10:15:44.000Z

Testing with the regular user snippets, they preserve tabstops if nested

Answer 23 · 2024-06-09T13:04:50.000Z

I found where the problem lies. In VSCode 1.86.0, at line 538 of the file src/vs/workbench/api/browser/mainThreadEditor.ts,

snippetController.insert(template, {
	overwriteBefore: 0, overwriteAfter: 0,
	undoStopBefore: opts.undoStopBefore, undoStopAfter: opts.undoStopAfter,
	clipboardText
});

has been replaced with

const edits: ISnippetEdit[] = ranges.map(range => ({ range: Range.lift(range), template }));
snippetController.apply(edits, {
   overwriteBefore: 0, overwriteAfter: 0,
   undoStopBefore: opts.undoStopBefore, undoStopAfter: opts.undoStopAfter,
   clipboardText
});

Reverting this change should allow the compiled vscode to function properly with hypersnips.

Answer 24 · 2024-06-09T13:11:37.000Z

Great job!! How did you find it? There were soooo many files and changes I gave up looking after a while.

I think the next step should be to find what part of hyprsnips interact with this feature, instead of patching vscode. Nested snippets still work with other snippet programs, so it must be possible.

Answer 25 · 2024-06-09T14:33:27.000Z

Searching through the files, I see no mention of this "snippetController". Do you know in what context it is used ?

Answer 26 · 2024-06-09T15:23:58.000Z

@yiktllw Thank you very much for finding the error. Can you detail the process as to how we can achieve the same? I tried cloning the repository and making the change, but I keep running in errors trying to compile the repository.

Answer 27 · 2024-06-09T15:48:03.000Z

@yiktllw Thank you very much for finding the error. Can you detail the process as to how we can achieve the same? I tried cloning the repository and making the change, but I keep running in errors trying to compile the repository.

I tried the latest source code of VSCode(1.90.0). After modifying

const edits: ISnippetEdit[] = ranges.map(range => ({ range: Range.lift(range), template }));
snippetController.apply(edits, {
	overwriteBefore: 0, overwriteAfter: 0,
	undoStopBefore: opts.undoStopBefore, undoStopAfter: opts.undoStopAfter,
	clipboardText
});

to

snippetController.insert(template, {
	overwriteBefore: 0, overwriteAfter: 0,
	undoStopBefore: opts.undoStopBefore, undoStopAfter: opts.undoStopAfter,
	clipboardText
});

I also removed

import { ISnippetEdit } from 'vs/editor/contrib/snippet/browser/snippetSession';

from the beginning of the file.
Following these changes, I was able to compile the code successfully.

Answer 28 · 2024-06-09T16:06:20.000Z

Searching through the files, I see no mention of this "snippetController". Do you know in what context it is used ?

It was mentioned at line 530 of the file:

// import { SnippetController2 } from 'vs/editor/contrib/snippet/browser/snippetController2';
const snippetController = SnippetController2.get(this._codeEditor);

I'm not sure about the specific usage of snippetController either.

Answer 29 · 2024-06-09T16:08:29.000Z

yeah I tried looking through any mentioned of everything mentioned above in both hsnips and in the hscope repo. I found nothing.

Answer 30 · 2024-06-09T16:12:19.000Z

@yiktllw Okay, I am able to change the line inside the src folder and I was also able to run the yarn and yarn watch commands on the terminal. However, I am not sure how to actually produce the application of vscode. Can you provide some instructions for that?

Answer 31 · 2024-06-09T16:16:40.000Z

yeah I tried looking through any mentioned of everything mentioned above in both hsnips and in the hscope repo. I found nothing.

I misunderstood you.
The issue arises when executing editor.insertSnippet() in Hypersnips, and mainThreadEditor.ts is responsible for implementing the insertSnippet() method. So, I checked what updates were made in version 1.86.0 of this file, which led me to the code causing the problem.

Answer 32 · 2024-06-09T16:19:18.000Z

@yiktllw Okay, I am able to change the line inside the src folder and I was also able to run the yarn and yarn watch commands on the terminal. However, I am not sure how to actually produce the application of vscode. Can you provide some instructions for that?

You need to run the yarn and yarn compile commands, and then you will find the executable files in the ./scripts folder. On Windows, it's "code.bat", and on Linux, it's "code.sh".

Answer 33 · 2024-06-09T16:34:13.000Z

@yiktllw Sorry for bothering you, but running code.sh opens a VScode application which has no extensions enabled nor can I find any extensions in it. Moreover, the app name is Code - OSS.

Answer 34 · 2024-06-09T16:39:12.000Z

@yiktllw Sorry for bothering you, but running code.sh opens a VScode application which has no extensions enabled nor can I find any extensions in it. Moreover, the app name is Code - OSS.

Have you cloned the right repo?

Answer 35 · 2024-06-09T16:41:21.000Z

@yiktllw Sorry for bothering you, but running code.sh opens a VScode application which has no extensions enabled nor can I find any extensions in it. Moreover, the app name is Code - OSS.

The compiled version of VSCode does not include any extensions and cannot access the marketplace. I'm not sure if this can be avoided. If you need to use extensions, you must download them from the web page marketplace and then select Install from VSIX from the menu in the top right corner of the Extensions view.
Therefore, recompiling VSCode is not the best option. A better approach would be to fix the issue within Hypersnips.

Answer 36 · 2024-06-09T16:44:33.000Z

@yiktllw Ah I see, so your discovery was more pertaining to having hypersnips patched up instead of providing us an a local solution to fix hypersnips for ourselves (as the compiled version of VScode looks far inferior to the Application VScode). With that said, I think it would be best to open up a new issue with the proposed discovery as this thread already has a lot of messages which the developers might not want to skim through.

Answer 37 · 2024-06-09T16:49:41.000Z

It does not seem like the original developer is interested in this or any other issue. The github profile has not been doing much lately. I even emailed him and have yet to get any response. The best solution, is to just figure out what the problem is, then just fork the project (I do not mind doing that).

On line 87 in hsnips/src/extention.ts we see the use of editor.insertSnippet. I am trying to see what could have went wrong.

Answer 38 · 2024-06-11T14:29:29.000Z

For any Arch Linux users reading this, just download the tar ball from 1.85 (other distros has their versions there as well), extract to some directory of choice, then just make a symlink from /usr/bin/code to the executable at VSCode-linux-x64/bin/code where ever you extracted it.

I'm sorry for loopingback to this, I tried downgrading this same way and correctly got VSC version 1.85.2 upon checking, but for some reason doesn't fix the problem. I there something dumb I might've overlooked?

Regardless, its great to see people spend time diagnosing this issue on others behalf.

Answer 39 · 2024-06-11T14:35:39.000Z

@FluffLescure
You might want to check if there are any conflicts between some plugins and Hypersnips. From what I know, the VSCode Vim plugin can also cause this issue (the VSCode Neovim plugin does not).

Answer 40 · 2024-06-11T15:49:08.000Z

For any Arch Linux users reading this, just download the tar ball from 1.85 (other distros has their versions there as well), extract to some directory of choice, then just make a symlink from /usr/bin/code to the executable at VSCode-linux-x64/bin/code where ever you extracted it.

I'm sorry for loopingback to this, I tried downgrading this same way and correctly got VSC version 1.85.2 upon checking, but for some reason doesn't fix the problem. I there something dumb I might've overlooked?

Regardless, its great to see people spend time diagnosing this issue on others behalf.

When you write code -v in the terminal, do you get the correct version? I use this version as well and can install hnsips through the marketplace inside vscode

Answer 41 · 2024-06-11T19:34:38.000Z

When you write code -v in the terminal, do you get the correct version?

Yep correct version pops up, VSC wasn't the issue.

@FluffLescure
You might want to check if there are any conflicts between some plugins and Hypersnips. From what I know, the VSCode Vim plugin can also cause this issue (the VSCode Neovim plugin does not).

Was using Vim extension rather than neovim, that was my mistake. Quick responses though, thanks guys!

Answer 42 · 2024-06-11T19:41:26.000Z

Okay, and what happens when you try to use the marketplace? Are you able to install hsnips, but it just does not activate? If so, have you checked the snippet file directory to see it is not empty?

Answer 43 · 2024-06-14T11:38:14.000Z

Marketplace works fine and snippet path was well configured since settings were kept across versions. It was just the Vim extension deleting tabstops for some reason. NVim fixed it with v1.85 of vsc

Answer 44 · 2024-08-17T20:39:09.000Z

@Oskar-Idland I tried latex utilities at 1.89.1 and 1.92.2 but they also deleted tabstops.
One could configure the build step of something like vscodium to change those lines back. Then you will still have the marketplace and an experience like the normal vscode. But some things will not work.

I don't know if its worth it to find a work around when vscode is probably gonna fix the bug of vscode.TextEditor.insertSnippet

Answer 45 · 2024-08-28T16:19:03.000Z

@superle3 I am not sure this is a bug, but just a refactoring. Latex Workshop no longer works on 1.85, so this makes this a lot more work to fit into a regular workflow. I think the only way is to actually sit down, learn this codebase and patch the API calls that do not work. I tried contacting the original developer, but he won't reply. I can try giving him a ping tho.

Answer 46 · 2024-08-28T16:25:58.000Z

@draivin Hey man, I know this is a FOSS project so I apologize for asking for your time. This is a suuuper useful project which I know many people use. It makes working on latex go from a chore, to a breeze. Please, if you are able, help us patch it up. We know what API calls that are problematic, but we do not have your knowlegde of the codebase. Please, update the code, or teach us how to do it our selves. I think many people (myself included) would be happy to fork the repo and continue the work, but a little help getting started would be amazing!

Answer 47 · 2024-09-13T13:32:38.000Z

After some inspection of the source code, i think the problem does not orginate from HyperSnips. hsnip use vscode.editor.insertSnippets() from the vscode api, i tried calling this function two times, the second time i called it the editor will just simpliy discard the tabstops from the first call. tested on vscode 1.93 (August 2024). At this moment, there is not way to retain previous tabstops when calling insertSnippets(). This is an issue with VSCode API itself.

Answer 48 · 2024-09-13T15:59:43.000Z

After some inspection of the source code, i think the problem does not orginate from HyperSnips. hsnip use vscode.editor.insertSnippets() from the vscode api, i tried calling this function two times, the second time i called it the editor will just simpliy discard the tabstops from the first call. tested on vscode 1.93 (August 2024). At this moment, there is not way to retain previous tabstops when calling insertSnippets(). This is an issue with VSCode API itself.

Would it be possible to also test it on the last known working version (v1.85 November 2023) and see if it discards the tabstops? I'm unfamiliar with how the API works or how to use it.

Answer 49 · 2024-09-13T16:47:54.000Z

After some inspection of the source code, i think the problem does not orginate from HyperSnips. hsnip use vscode.editor.insertSnippets() from the vscode api, i tried calling this function two times, the second time i called it the editor will just simpliy discard the tabstops from the first call. tested on vscode 1.93 (August 2024). At this moment, there is not way to retain previous tabstops when calling insertSnippets(). This is an issue with VSCode API itself.

I agree with you. In fact, I've reported this bug to VSCode: microsoft/vscode#214757. As mentioned in the issue, this bug is caused by microsoft/vscode@9f5cb95.

Answer 50 · 2024-09-13T17:26:04.000Z

After some inspection of the source code, i think the problem does not orginate from HyperSnips. hsnip use vscode.editor.insertSnippets() from the vscode api, i tried calling this function two times, the second time i called it the editor will just simpliy discard the tabstops from the first call. tested on vscode 1.93 (August 2024). At this moment, there is not way to retain previous tabstops when calling insertSnippets(). This is an issue with VSCode API itself.

Great job! I hope everyone here interacts with issue 214757. It will increase the odds of it being looked at.

Answer 51 · 2024-09-13T17:43:52.000Z

@yiktllw thank you for reporting the bug! I have also commented there ♥️ @Oskar-Idland

Answer 52 · 2024-09-14T12:10:24.000Z

@XRay71 on 1.85.2 it did not delete tabstop/ behaved normally until 19 of the same insertSnippet was called. independent on how many tabstops there were in the insertSnippet call. So it "worked" as expected

Answer 53 · 2024-09-18T22:15:47.000Z

I have a temporary solution to the problem. modifying extensions.ts:86:90 reverses the behavior.

  await vscode.commands.executeCommand('editor.action.insertSnippet', { "snippet": snippetInstance.snippetString.value });
  // await editor.insertSnippet(snippetInstance.snippetString, insertionRange, {
  //   undoStopAfter: false,
  //   undoStopBefore: false,
  // });

it's not the most elegant but can't figure out why vscode.TextEditor.insertSnippet doesn't work, esp. since the proposed seems to use it under the hood.

also @Oskar-Idland it'd probably be good to transfer ownership of this repo from @draivin. mind reaching out to him?

Answer 54 · 2024-09-20T14:13:36.000Z

@PiotrSokol
thanks for finding a workaround/solution.
but wouldn't

await vscode.commands.executeCommand("editor.action.insertSnippet", {
    snippet: snippetInstance.snippetString.value,
    location: insertionRange,
    options: { undoStopAfter: false, undoStopBefore: false },
  });

be better since I assume this would preserve the original options.

also this will probably need to be forked, since the author does not seem to be active

Answer 55 · 2024-09-20T14:46:45.000Z

Thank you all for finding the solution. I am unable to make this modification as I can't locate the stated file. Can somebody assist me in locating it?

Answer 56 · 2024-09-20T17:02:48.000Z

its in src/extension.ts in this github repo.
in your local installation its in ~/.vscode/extensions/draivin.hsnips-0.2.9/out/extension.js

edit: for @Alex2134556

Answer 57 · 2024-09-22T19:42:29.000Z

I have a temporary solution to the problem. modifying extensions.ts:86:90 reverses the behavior.
  await vscode.commands.executeCommand('editor.action.insertSnippet', { "snippet": snippetInstance.snippetString.value });
  // await editor.insertSnippet(snippetInstance.snippetString, insertionRange, {
  //   undoStopAfter: false,
  //   undoStopBefore: false,
  // });
it's not the most elegant but can't figure out why vscode.TextEditor.insertSnippet doesn't work, esp. since the proposed seems to use it under the hood.

also @Oskar-Idland it'd probably be good to transfer ownership of this repo from @draivin. mind reaching out to him?

I have messaged him here, and sent an email many months ago. I do not think we should bet on him to return. I would be happy to fork the project, and will accept any working solution!

Answer 58 · 2024-09-22T19:46:07.000Z

The fork is made https://github.com/Oskar-Idland/hsnips

Answer 59 · 2024-09-24T16:17:48.000Z

I edited the part you mentioned @superle3, but I was not able to make it work. I do not know if this happens to anyone else, but without the HyperSnips for Math by OrangeX4 (a fork made in 20201), I do not get any snippets at all. I am currently using vscode version 1.93.1. Any one else have both installed?? It makes sense that your fix does not work if HyperSnips does not work, but I was curious if anyone else MUST have the fork installed?

Answer 60 · 2024-09-24T16:20:02.000Z

I got it to work by modifying the .js files in the "out" folder of the actual extension in my local installation, but modifying the .ts files didn't work for me. Am on the latest version of vscode

Answer 61 · 2024-09-24T16:22:20.000Z

Same as @XRay71. The file is located at the same place on a linux OS, as in the repo: ~/.vscode/extensions/draivin.hsnips-0.2.9/out/extension.js. I assume it will be similar for mac, and windows somewhere in the AppData folder

Answer 62 · 2024-09-24T16:25:37.000Z

I'm unfamiliar with how TypeScript works, but I do believe that it's supposed to be a compiled language; maybe you need to recompile the extension to JavaScript after modifying it to get it to work?

Answer 63 · 2024-09-24T16:50:56.000Z

You are right hahahah. Ofc it needs to be compiled. But then we must edit the typescript, then compile right? I have no experience with either language. It seems like we need to use tsc -p tsconfig.json in the extension folder, but I get errors as I am missing the vscode module and other

tsc -p tsconfig.json

output

src/completion.ts(1,25): error TS2307: Cannot find module 'vscode' or its corresponding type declarations.
src/dynamicRange.ts(1,25): error TS2307: Cannot find module 'vscode' or its corresponding type declarations.
src/extension.ts(1,25): error TS2307: Cannot find module 'vscode' or its corresponding type declarations.
src/extension.ts(2,78): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
src/extension.ts(3,23): error TS2307: Cannot find module 'path' or its corresponding type declarations.
src/extension.ts(81,6): error TS7006: Parameter 'eb' implicitly has an 'any' type.
src/extension.ts(164,45): error TS7006: Parameter 'document' implicitly has an 'any' type.
src/extension.ts(174,8): error TS7006: Parameter 'editor' implicitly has an 'any' type.
src/extension.ts(174,16): error TS7006: Parameter '_' implicitly has an 'any' type.
src/extension.ts(182,47): error TS7006: Parameter 'e' implicitly has an 'any' type.
src/extension.ts(225,51): error TS7006: Parameter 'e' implicitly has an 'any' type.
src/extension.ts(227,32): error TS7006: Parameter 's' implicitly has an 'any' type.
src/hsnippetInstance.ts(1,25): error TS2307: Cannot find module 'vscode' or its corresponding type declarations.
src/hsnippetInstance.ts(178,7): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
src/hsnippetInstance.ts(251,23): error TS7006: Parameter 'edit' implicitly has an 'any' type.
src/parser.ts(143,63): error TS2580: Cannot find name 'require'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
src/utils.ts(1,25): error TS2307: Cannot find module 'vscode' or its corresponding type declarations.
src/utils.ts(2,23): error TS2307: Cannot find module 'path' or its corresponding type declarations.
src/utils.ts(3,21): error TS2307: Cannot find module 'os' or its corresponding type declarations.
src/utils.ts(56,37): error TS18047: 'hsnipsPath' is possibly 'null'.
src/utils.ts(70,39): error TS18047: 'hsnipsPath' is possibly 'null'.
src/utils.ts(106,11): error TS2322: Type 'string | null' is not assignable to type 'string'.
  Type 'null' is not assignable to type 'string'.
src/utils.ts(131,17): error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
src/utils.ts(132,14): error TS2580: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node`.
types/hscopes.d.ts(1,25): error TS2307: Cannot find module 'vscode' or its corresponding type declarations.

Answer 64 · 2024-09-24T17:03:00.000Z

Hey, @OrangeX4. As you have some experience with this project would you please help us out and get this project running again? With a bit of help, I can continue my own fork, but it is a bit hard to get started without help from a creator or contributor. For now, only fork work on my linux machine. How much did you change? Any help to get us independent would be greatly appreciated!

Answer 65 · 2024-09-25T07:10:52.000Z

@Oskar-Idland, do you have the HyperScope extension installed?
I made the changes as specified by @superle3 and got it running without issues (and without installing the OrangeX4 fork).

After cloning the repo and opening the folder, I ran the following code lines in the hsnip folder

npm install -g @vscode/vsce
npm install

The first installs a utility to create a .visx package globally (didn't make it work locally).
The second installs all necessary packages as specified in the project.
Then pressing F5 to debug the extension, should run tsc -p ./ automatically (see package.json).

Tbh, I have no idea about typescript (I am not even a developer), but that worked for me.

Answer 66 · 2024-09-25T20:19:05.000Z

idk if this is necessary but to reiterate.
For a LOCAL change on windows 10 native I got it to work by changing
the file ~/.vscode/extensions/draivin.hsnips-0.2.9/out/extension.js (unix path here but should still work)
where ~ is your userhome, can be found by cd ~ in powershell, does not work in explorer.
if dravin ever updates the extension and this is still an issue the version number 0.2.9 will be different in the folder.
unix systems should also have a home like folder where it is but i don't use mac or unix so look up vscode documentation yourself.

For the REPO change, so to make a new version not a local change you change src/extension.ts

the change in question

await vscode.commands.executeCommand("editor.action.insertSnippet", {
    snippet: snippetInstance.snippetString.value,
    location: insertionRange,
    options: { undoStopAfter: false, undoStopBefore: false },
  });
   // await editor.insertSnippet(snippetInstance.snippetString, insertionRange, {
  //   undoStopAfter: false,
  //   undoStopBefore: false,
  // });

hope this helps and this may be a bit too much explanation but I have been stuck at not knowing what ~ or home is since it doesn't work in explorer (don't judge me)

Answer 67 · 2024-09-25T20:50:46.000Z

Thanks for a good summary! We'll figure it out together

Answer 68 · 2024-09-25T21:16:20.000Z

I'll fork the repo and figure out how to publish it to the vscode extension marketplace. AFAIK, need to verify myself so give me a few days.

For now look up locally packaging the extension. You'll need yarn/npm, and vsce.

Answer 69 · 2024-09-25T21:52:51.000Z

The change was easy to implement, and both direct edit and compilation was without issue. I have just noticed how the extension does not work at all on my linux machine. Anyone else have this issue? I looked at the output in the terminal from the "extension host" and found the snippet not able to activate:

extension host output

Activating extension draivin.hsnips failed due to an error:
2024-09-25 23:02:52.598 [error] Error: ENOTEMPTY: directory not empty, rename '/home/oskar/.config/Code/User/hsnips' -> '/home/oskar/.config/Code/User/globalStorage/draivin.hsnips/hsnips'
	at renameSync (node:fs:1032:11)
	at activate (/home/oskar/.vscode/extensions/draivin.hsnips-0.2.9/out/extension.js:85:33)
	at q.kb (/opt/visual-studio-code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:167:13836)
	at q.jb (/opt/visual-studio-code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:167:13508)
	at /opt/visual-studio-code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:167:11493
	at async m.n (/opt/visual-studio-code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:151:6409)
	at async m (/opt/visual-studio-code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:151:6372)
	at async m.l (/opt/visual-studio-code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:151:5829)

The second line of the indented block references something being wrong on 85:33 in extension.js. Looking further at this I found this block:

function activate(context) {
    var _a;
    (_a = vscode.extensions.getExtension('draivin.hscopes')) === null || _a === void 0 ? void 0 : _a.activate();
    // migrating from the old, hardcoded directory to the new one. TODO: remove this at some point
    const oldGlobalSnippetDir = (0, utils_1.getOldGlobalSnippetDir)();
    if ((0, fs_1.existsSync)(oldGlobalSnippetDir)) {
        // only the global directory needs to be migrated, which is why `ignoreWorkspace` is set to `true` here
        const newSnippetDirInfo = (0, utils_1.getSnippetDirInfo)(context, { ignoreWorkspace: true });
        if (newSnippetDirInfo.type == utils_1.SnippetDirType.Global) {
            (0, fs_1.mkdirSync)(path.dirname(newSnippetDirInfo.path), { recursive: true });
            (0, fs_1.renameSync)(oldGlobalSnippetDir, newSnippetDirInfo.path);
        }
    }

At relative linenumber 5 or absolute linenumber 79, I se the use of getGlobalSnippetDir(), which is defined in out/utils.js:

/**
 * @deprecated The paths here are hardcoded in. Only keep this function so that older users can migrate.
 */
function getOldGlobalSnippetDir() {
    let hsnipsPath = vscode.workspace.getConfiguration('hsnips').get('hsnipsPath');
    if (hsnipsPath && path.isAbsolute(hsnipsPath)) {
        return hsnipsPath;
    }

This seems like a an old file structure, renamed, but with legacy code to keep everyone on board. I have neither platform == 'darwin' or platform == 'win32', so the path should be correct at ~/.config/Code/User/hsnips as written in the else-block. The problem must therefore be at the use of renameSync at line 85 in extension.js. I commented out this entire block on line 78 of extension.js in activate(context) and it worked again!

function activate(context) {
    var _a;
    (_a = vscode.extensions.getExtension('draivin.hscopes')) === null || _a === void 0 ? void 0 : _a.activate();
    //// migrating from the old, hardcoded directory to the new one. TODO: remove this at some point
    // const oldGlobalSnippetDir = (0, utils_1.getOldGlobalSnippetDir)();
    // if ((0, fs_1.existsSync)(oldGlobalSnippetDir)) {
        // only the global directory needs to be migrated, which is why `ignoreWorkspace` is set to `true` here
        const newSnippetDirInfo = (0, utils_1.getSnippetDirInfo)(context, { ignoreWorkspace: true });
        // if (newSnippetDirInfo.type == utils_1.SnippetDirType.Global) {
        //     (0, fs_1.mkdirSync)(path.dirname(newSnippetDirInfo.path), { recursive: true });
        //     (0, fs_1.renameSync)(oldGlobalSnippetDir, newSnippetDirInfo.path);
        // }
    // }
    loadSnippets(context);

As this is legacy, I might remove it on my new fork. Hopefully anyone in the same situation as I was can use this.

Answer 70 · 2024-09-25T23:03:59.000Z

I applied the change as summarized by @superle3 to the fork of hsnips by @OrangeX4, and it worked as well! This fork has more features, like a math flag, VISUAL variable for selection, a great starting config and amazing matrix/table support. This fork was last updated in march 2023. If the creator of the fork is busy or not interested, I believe it to be better to fork @OrangeX4's fork again with the update. I can figure out how to release an extension this weekend. Does this sound like a good solution?

Answer 71 · 2024-09-26T03:36:27.000Z

Something which may be related to this issue is the fact that nested tabstops also sometimes get mixed up with the outer tabstops. For example, if I have a snippet that generates, say, 10 tabstops (a_1, ..., a_10), and then use another snippet inside that generates, say, 90 tabstops (b_1, ..., b_10), I find that the order of tabstops goes b_1, ..., b_9, a_1, b_10, ..., b_17, a_2, etc.

I've read through the code several times in search of where this behaviour may be coming from, but came up with nothing, so I believe it may also be an issue with the VSCode API. Can anyone replicate?

Answer 72 · 2024-09-26T11:23:19.000Z

Something which may be related to this issue is the fact that nested tabstops also sometimes get mixed up with the outer tabstops. For example, if I have a snippet that generates, say, 10 tabstops (a_1, ..., a_10), and then use another snippet inside that generates, say, 90 tabstops (b_1, ..., b_10), I find that the order of tabstops goes b_1, ..., b_9, a_1, b_10, ..., b_17, a_2, etc.

I've read through the code several times in search of where this behaviour may be coming from, but came up with nothing, so I believe it may also be an issue with the VSCode API. Can anyone replicate?

@superle3 and @PiotrSokol had both different solutions to the original problem. Do both solutions create this problem?

Answer 73 · 2024-09-26T14:47:55.000Z

@XRay71 could you send the snippet that caused this problem and is does the change only partially work or just not at all.
Because im not able to replicate it with

snippet trigger1 "Trigger 1" i
b_${1} b_${2} b_${3} b_${4} b_${5} b_${6} b_${7} b_${8} b_${9} b_${10}
endsnippet

snippet trigger2 "Trigger 2" i
a_${1} a_${2} a_${3} a_${4} a_${5} a_${6} a_${7} a_${8} a_${9} a_${10}
endsnippet

also I haven't found a difference between the two implentations. It SHOULD give different behavior for undo but it doesn't. Seems like another bug. The documentation is a bit vague https://vscode-api.js.org/interfaces/vscode.TextEditor.html .
But doing C-Z after trigger1 reverts back to nothing. this does still work with 1.85.2 and with normal vscode snippets

edit: I think this is because

await editor.edit(
    (eb) => {
      eb.delete(snippetExpansion ? completion.completionRange : completion.range);
    },
    { undoStopAfter: false, undoStopBefore: !snippetExpansion },
  );

is broken, where the undoStopBefore isn't happening

Answer 74 · 2024-09-26T14:51:28.000Z

I have tried both of their solutions, both still contain this issue.

snippet expand1 A
``let out = "", order = 1; for (let i = 0; i < 10; i++) out += " | " + snip.tabstop(order++); rv = out;``
endsnippet

snippet expand2 A
``let out = "", order = 1; for (let i = 0; i < 30; i++) out += " | " + snip.tabstop(order++); rv = out;``
endsnippet

@superle3
I am also able to replicate it with your snippet there.
Try running trigger1 and then immediately trigger2, then tab to the final "a". You will see that both the final "a" and the second "b" tabstops are highlighted.

Answer 75 · 2024-09-26T15:00:25.000Z

@XRay71 oh yes you're right, I didn't check if it worked when I pressed tab. Though this is "expected behaviour" it seems.
same behaviour in 1.85.2 and for normal snippets. Another bug to report to vscode.

[
	"test1": {
		"prefix": "test1",
		"body": [
			"a_$1 a_$2 a_$3 a_$4 a_$5 a_$6 a_$7 a_$8 a_$9 a_$10"
		],
		"description": "test1"
	},
	"test2": {
		"prefix": "test2",
		"body": [
			"b_$1 b_$2 b_$3 b_$4 b_$5 b_$6 b_$7 b_$8 b_$9 b_$10"
		],
		"description": "test2"
	}]

Answer 76 · 2024-09-26T20:19:55.000Z

I have made a new repo, and published to the marketplace. Would love to collaborate! See HyperSnips V2 on github or marketplace

Answer 77 · 2024-09-30T17:42:10.000Z

@XRay71 I reported this to vscode in microsoft/vscode#230149.
Everyone please also upvote this issue to create attention to it