drupal-graphql/graphql

PHPCS error 'string' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)

avinash2209 opened this issue · 4 comments

avinash2209 commented

PHPCS check for PHP 8.2 compatibility gives following error
Command run: phpcs -d memory_limit=-1 --standard=vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.2- ./ --report-full=./php-csreport.log --extensions=php,inc,module,install -p

`FILE: /graphql/src/Plugin/GraphQL/DataProducer/String/Uppercase.php

FOUND 1 ERROR AFFECTING 1 LINE

3 | ERROR | 'string' is a reserved keyword as of PHP version 7.0 and should not be used to name a class, interface or trait or as part of a namespace (T_NAMESPACE)
---------------------------------------------------------------------------------------------------------------------------------------------------------------------`

Kingdutch commented

👋 Thanks for your issue.

I'm not sure what coding standard you're running but it's not one that we support with the GraphQL module. The coding standard itself is also incorrect in that string is a reserved word but namespaces are treated as single-entities and not as individual words so the string reservation doesn't apply to it. I explained this with sources somewhere else but couldn't find it.

You can also see it by the fact that the namespace only errors on PHP 5.2 and older which is because namespaces were introduced in PHP 5.3 :) At no point does PHP provide a notice/warning/error that String should not be part of the namespace.

Closing this as won't fix :)

Kingdutch commented

Your referenced doc states "The following words cannot be used to name a class, interface or trait. Prior to PHP 8.0, they are also prohibited from being used in namespaces. "

So as of PHP 8.0 it's officially fine to use those words in namespaces, so if php-compatibility is saying that it's disallowed for PHP 8.2 then that's a bug in the tool :D