Object.dirname is deprecated.
ljsinclair opened this issue · 4 comments
ljsinclair commented
Argument to path.dirname
must be a string
Object.dirname (C:\Users\gothe\AppData\Local\atom\app-1.28.0\resources\app.asar\src\electron-shims.js:9:10)
transformLinks (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:42:16)
MarkdownMindmapView.parseMarkdown (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:398:32)
MarkdownMindmapView.renderMarkdownText (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:403:19)
<unknown> (C:\Users\gothe\.atom\packages\markdown-mindmap\lib\markdown-mindmap-view.coffee:242:26)
<unknown> (null:null:null)
hueri commented
Also seeing this - bummer, as it worked in a previous version!
dundalek commented
I was able to give it a look today. I cannot reproduce the issue, so it is probably a bug in the parser which is probably caused by some particular markdown. It would be helpful if you could share the markdown content with which you encounter this issue (make sure to redact out any private and sensitive content before sharing).
hueri commented
i just tried again (reverting the change), and i’m seeing what you’re seeing (functional, but with the error). Previously, it wasn’t opening the mindmap-markdown window, and would only bring up the error console.
The markdown test had been super-simple.
# test
## stuff here
### other
i’ll leave it to you for next steps - thanks for even looking!
On Aug 11, 2019, at 8:28 AM, Jakub Dundalek <notifications@github.com<mailto:notifications@github.com>> wrote:
I was able to give it a look today. I cannot reproduce the issue, so it is probably a bug in the parser which is probably caused by some particular markdown. It would be helpful if you could share the markdown content with which you encounter this issue (make sure to redact out any private and sensitive content before sharing).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#43?email_source=notifications&email_token=ALYP2YHOJ2B72HDEEYUM5LTQEAV3JA5CNFSM4HHJEEQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4BDASI#issuecomment-520237129>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ALYP2YGFN4224CK3ZKH2JIDQEAV3JANCNFSM4HHJEEQQ>.
dundalek commented
Should be fixed in the latest version 0.6.2
.