push is really concat
dustingetz opened this issue · 1 comments
dustingetz commented
push is really concat
dustingetz commented
Daniel Miladinov - 8:11 AM
So I’m looking at your update-in issue, push is concat - #2
Do you want to add concat as an alias to push, or replace push with concat altogether (I imagined I’d still call out to react-addons/update:$push underneath, because it’s doing the right thing)
Dustin Getz - 8:33 AM
the isuse i believe is that addons.$push takes an array argument
which confuses me and everyone else when we intuitively pass it a value and it fails
Dustin Getz - 8:49 AM
however the change i suggest in that issue breaks backwards compat, so i dont know, i will need to at least consult Andrew