24 Tests Fail on Master Branch
nelsonic opened this issue · 5 comments
Hi @th0mas, hope your morning is going well.
I tried to run the tests on the master branch of this project on my localhost and I get the following error:
Appears to be related to the feature flags. 💭
This is matches what we see on Travis-CI where the last few builds have failed:
https://travis-ci.com/github/dwyl/smart-home-auth-server/branches
The most recent master build is:
https://travis-ci.com/github/dwyl/smart-home-auth-server/builds/178230954#L892
Please take a look at the failing tests and ensure that they all pass on master (create a branch/PR to fix the tests)
and let me know when it's done so I can proceed with the Heroku deployment #14
Thanks. ✨
@nelsonic Yeah I was delaying rewriting the tests until the authorization system properly working with RBAC as ~60% of the tests and systems will be affected by this. I'm happy to try and fix the tests that are broken now but I won't aim for a high coverage until RBAC is complete and I know how much of the hub needs to be adapted
Ah ... OK. If this is dependent on RBAC, please see/answer #1 (comment) ❓
I will switch back to RBAC now and focus on that. 👍
Its not RBAC dependent per se, and there's still a few broken tests from #7 that I'll fix now and I'll comment out all the authorization tests for now so we can get deployment working.
But most of the tests will rely on a RBAC implementation so we'll probably only end up with 30-40% coverage for now.