pin HARK dependency in requirements.txt ?
sbenthall opened this issue · 5 comments
We release DemARKs on the same release cycle as HARK. (Currently, it has a 0.10.8 release)
We test DemARKs against HARK master
so we can catch errors before the next release.
But we so far are not pinning the HARK dependency to the corresponding version of DemARK.
I think we should: version X of DemARK should have its HARK dependency pinned to X.
Right?
Looks like the binder instance uses HARK master currently:
https://github.com/econ-ark/DemARK/blob/master/binder/requirements.txt#L12
If it were pinned to 0.10.8, then it wouldn't have this issue.
When we click on the binder launch button it takes us to https://mybinder.org/v2/gh/econ-ark/DemARK/master
If we want to launch the DemARKs in 0.10.8 we should rather go to https://mybinder.org/v2/gh/econ-ark/DemARK/0.10.8. The 0.10.8 tag will also fail currently as I missed the step of swapping in explicit version of HARK in requirements.txt when making a release of DemARKs.
This should become a part of the release procedure.
I am not 100% sure how to document the https://mybinder.org/v2/gh/econ-ark/DemARK/master, https://mybinder.org/v2/gh/econ-ark/DemARK/0.10.8, https://mybinder.org/v2/gh/econ-ark/DemARK/0.10.7, ...... part.
Should we just add this in the README?