Mind if I rewrite to use SIPhash and speed-optimize?

Question

Mind if I rewrite to use SIPhash and speed-optimize?

Closed this issue 8 years ago · 2 comments

Hi, Bin - do you mind if I rewrite the internals to use SIPhash as the default hash function, and add a few speed optimizations and a benchmark? I'd like to try to make this even more attractive for people to use out of the box.

Answer 1 · 2016-11-29T18:03:12.000Z

Sure dave. Go ahead and thanks I'll also try reorganizing the src code a bit with google style.

…

On Tue, Nov 29, 2016 at 9:58 AM David Andersen ***@***.***> wrote: Hi, Bin - do you mind if I rewrite the internals to use SIPhash as the default hash function, and add a few speed optimizations and a benchmark? I'd like to try to make this even more attractive for people to use out of the box. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABWSdJ0uYr6UVn05evrprI804Jc5F9p9ks5rDGfVgaJpZM4K_SKV> .

Answer 2 · 2016-12-12T20:52:41.000Z

Obviated by jbapple's PR. Closing.