ekansa/open-context-py

Put base Solr URL and port into secrets.json

Closed this issue · 2 comments

Looking at: https://github.com/ekansa/open-context-py/blob/solr-indexer-additions/opencontext_py/apps/index/crawler.py

It might be good to put the base Solr URL and port in the secrets.json file. It's a good place to keep configuration information that may be a potential security issue?

Or should it go in settings.py?

That's a good point. It's probably good to keep this information in the
secrets file (or use an environment variable). Ideally, we only listen for
solr requests from localhost, but it's still a good idea to keep
configuration like this secret.

On Mon, Jun 23, 2014 at 1:53 PM, Eric Kansa notifications@github.com
wrote:

Looking at:
https://github.com/ekansa/open-context-py/blob/solr-indexer-additions/opencontext_py/apps/index/crawler.py

It might be good to put the base Solr URL and port in the secrets.json
file. It's a good place to keep configuration information that may be a
potential security issue?

Or should it go in settings.py?


Reply to this email directly or view it on GitHub
#1.

forgot to close this, it was implemented 9 months ago...