Text of code block within a info admonition block is barely legible in darkmode
garazdawi opened this issue · 5 comments
See erlang/otp#8151 for an example.
Not 100% sure if it is the text or background that should be updated?
As the light theme has dark-on-light code, I would think light-on-dark for the dark theme. @josevalim?
@DavidOliver please pull latest and run mix build. I have created an example page with all admonition blocks so we can take a look at it in dev.
The issue above only happened if there was no language selected, otherwise we should light on dark, so it was an easy fix. But your feedback on the example page is very welcome.
Good good - looks fine to me in the context of the current approach.
I would be up for experimenting with dark admonition block background colours for the dark theme, creating the inverse of the light theme, so that there's less bright tone in general, which I think is what dark theme users tend to prefer, if you'd be interested.
It is up to you. :)
Okay. :) I'll have a go at that and submit a PR if I think it's worth considering before looking at #1866.