Odd behaviour of evil-surround-region in visual line mode

[fivethousand]

Description

evil-surround-region behaviour has changed for visual line mode

Reproduction guide

• start Emacs
• write a couple of lines, (for example qwe, asd, zxc)
• select lines, press s (or S, whatever maps to evil-surround-region), press {

Observed behaviour:
{qwe
asd
zxc}

Expected behaviour:
{
qwe
asd
zxc
}

For visual and visual block mode, the observed behaviour is expected and correct, for visual line mode it is wrong imho. This has changed recently, before it did work as expected.

See
syl20bnr/spacemacs#5358

[fivethousand]

Btw: This deviates from vim-surround.

[opsound]

I am seeing the same unexpected behavior.

[hlissner]

My bad (my PR made this change)! I'm working on a PR for this now.

Until I've fixed this, it is evil-Surround-region that gives you the expected behavior. This is normally bound to gS.