emacs-helm/helm

"helm-split-window-default-side 'other" and helm-always-two-windows

karbiv opened this issue · 3 comments

karbiv commented

What happened?

This setting should work as expected, using other existing window for Helm buffer:

(setq helm-split-window-default-side 'other)

It doesn't.
It is masked by helm-always-two-windows that is by default is t in Helm. It makes Helm delete other windows before helm-split-window-default-side looks for it, and in result splits windows always horizontally.

How to reproduce?

In emacs-helm.sh scratch buffer eval:

(setq helm-split-window-default-side 'other)

Create other vertical window "C-x 3". Open Helm buffer.

Helm Version

Master branch

Emacs Version

Emacs-29.1

OS

GNU/Linux

Relevant backtrace (if possible)

No response

Minimal configuration

  • I agree using a minimal configuration
thierryvolpiatto commented
karbiv commented

Not with helm-always-two-windows.

From user's point of view "other window" is still "two windows", but it requires to turn off helm-always-two-windows.
And it looks like this:

(setq
    helm-always-two-windows nil
    helm-split-window-default-side 'other)

Somewhat strange after seeing that in Vertico it's one unambiguous configuration var.

There's third needed config var, helm-split-window-other-side-when-one-window 'right.
But this one is logical, to retain vertical split after toggling Helm full frame on&off.