envoyproxy/envoy-filter-example

Envoy tests fail with missing 'protoc'

jrajahalme opened this issue · 5 comments

jrajahalme commented

Following the readme, everything else works, but the last option to run all the envoy tests. It fails with this:

INFO: Found 522 targets and 148 test targets...
ERROR: missing input file '@envoy//ci/prebuilt:thirdparty_build/bin/protoc'.
ERROR: /home/vagrant/.cache/bazel/_bazel_vagrant/20ac4282102046f33dfec48128432a91/external/envoy/ci/prebuilt/BUILD:86:1: @envoy//ci/prebuilt:protoc: missing input file '@envoy//ci/prebuilt:thirdparty_build/bin/protoc'.
ERROR: /home/vagrant/.cache/bazel/_bazel_vagrant/20ac4282102046f33dfec48128432a91/external/envoy/ci/prebuilt/BUILD:86:1 1 input file(s) do not exist.
INFO: Elapsed time: 456.258s, Critical Path: 0.94s
@envoy//test/common/access_log:access_log_manager_impl_test           NO STATUS
@envoy//test/common/api:api_impl_test                                 NO STATUS
...

However, the build log for protobuf.dep.log shows 'protoc' has been built and installed:

 /bin/mkdir -p '/home/vagrant/.cache/bazel/_bazel_vagrant/20ac4282102046f33dfec48128432a91/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f/thirdparty_build/bin'
  /bin/bash ../libtool   --mode=install /usr/bin/install -c protoc '/home/vagrant/.cache/bazel/_bazel_vagrant/20ac4282102046f33dfec48128432a91/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f/thirdparty_build/bin'
libtool: install: /usr/bin/install -c protoc /home/vagrant/.cache/bazel/_bazel_vagrant/20ac4282102046f33dfec48128432a91/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f/thirdparty_build/bin/protoc

And the binary actually runs, too:

~/dev/envoy-filter-example$ /home/vagrant/.cache/bazel/_bazel_vagrant/20ac4282102046f33dfec48128432a91/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f/thirdparty_build/bin/protoc 
Usage: /home/vagrant/.cache/bazel/_bazel_vagrant/20ac4282102046f33dfec48128432a91/external/envoy_deps_cache_2c744dffd279d7e9e0910ce594eb4f4f/thirdparty_build/bin/protoc [OPTION] PROTO_FILES
Parse PROTO_FILES and generate output based on the options given:
  -IPATH, --proto_path=PATH   Specify the directory in which to search for
                              imports.  May be specified multiple times;
                              directories will be searched in order.  If not
                              given, the current working directory is used.
  --version                   Show version info and exit.
  -h, --help                  Show this text and exit.
  --encode=MESSAGE_TYPE       Read a text-format message of the given type
                              from standard input and write it in binary
                              to standard output.  The message type must
                              be defined in PROTO_FILES or their imports.
  --decode=MESSAGE_TYPE       Read a binary message of the given type from
                              standard input and write it in text format
                              to standard output.  The message type must
                              be defined in PROTO_FILES or their imports.
  --decode_raw                Read an arbitrary protocol message from
                              standard input and write the raw tag/value
                              pairs in text format to standard output.  No
                              PROTO_FILES should be given when using this
                              flag.
  --descriptor_set_in=FILES   Specifies a delimited list of FILES
                              each containing a FileDescriptorSet (a
                              protocol buffer defined in descriptor.proto).
                              The FileDescriptor for each of the PROTO_FILES
                              provided will be loaded from these
                              FileDescriptorSets. If a FileDescriptor
                              appears multiple times, the first occurrence
                              will be used.
  -oFILE,                     Writes a FileDescriptorSet (a protocol buffer,
    --descriptor_set_out=FILE defined in descriptor.proto) containing all of
                              the input files to FILE.
  --include_imports           When using --descriptor_set_out, also include
                              all dependencies of the input files in the
                              set, so that the set is self-contained.
  --include_source_info       When using --descriptor_set_out, do not strip
                              SourceCodeInfo from the FileDescriptorProto.
                              This results in vastly larger descriptors that
                              include information about the original
                              location of each decl in the source file as
                              well as surrounding comments.
  --dependency_out=FILE       Write a dependency output file in the format
                              expected by make. This writes the transitive
                              set of input file paths to FILE
  --error_format=FORMAT       Set the format in which to print errors.
                              FORMAT may be 'gcc' (the default) or 'msvs'
                              (Microsoft Visual Studio format).
  --print_free_field_numbers  Print the free field numbers of the messages
                              defined in the given proto files. Groups share
                              the same field number space with the parent 
                              message. Extension ranges are counted as 
                              occupied fields numbers.

  --plugin=EXECUTABLE         Specifies a plugin executable to use.
                              Normally, protoc searches the PATH for
                              plugins, but you may specify additional
                              executables not in the path using this flag.
                              Additionally, EXECUTABLE may be of the form
                              NAME=PATH, in which case the given plugin name
                              is mapped to the given executable even if
                              the executable's own name differs.
  --cpp_out=OUT_DIR           Generate C++ header and source.
  --csharp_out=OUT_DIR        Generate C# source file.
  --java_out=OUT_DIR          Generate Java source file.
  --javanano_out=OUT_DIR      Generate Java Nano source file.
  --js_out=OUT_DIR            Generate JavaScript source.
  --objc_out=OUT_DIR          Generate Objective C header and source.
  --php_out=OUT_DIR           Generate PHP source file.
  --python_out=OUT_DIR        Generate Python source file.
  --ruby_out=OUT_DIR          Generate Ruby source file.

This from a freshly cloned lyft/envoy-filter-example, following the instructions on README.md.

jrajahalme commented

Searching around I found someone else has hit the same exact issue: https://pastebin.com/SQKUYEiM

mattklein123 commented

@htuch any ideas?

htuch commented

Not immediately, I'll take a look at this tomorrow.

htuch commented

This is just the //... vs. //test/... issue, due to the way that the CI prebuilt BUILD file works issue. I'll update README.md with the correct instructions.

jrajahalme commented