Expain that `targen` is only for the test chart editor
Opened this issue · 9 comments
Describe the bug
Title
To Reproduce
- Add anything including junk which should result in a different output file
- Do profiling run
- Doesn't error out after testchart completion
Versions:
- Distro:
Gentoo
- Python:
3.12.4
- ArgyllCMS
3.2.0
- DisplayCAL: eda4243
As I see extra arguments to targen
is only passed when you use the Test Chart Editor:
Command line:
/Users/eoyilmaz/Library/Application Support/DisplayCAL/dl/Argyll_V3.3.0/bin/targen
-v
-d3
-e4
-B4
-s17
-g52
-m17
-b0
-f0
-V1.0
-p1.0
'asdfj;lkasjd'
'jsa;ldfja;s'
'ldfj;alksdjf;'
'lkajs;dk'
j
temp
as you see my gibberish is passed to the targen
command.
If it is intentional it should probably be disclosed somewhere.
From this line in the history.template.html
:
displaycal-py3/misc/history.template.html
Line 740 in 4553d65
I understand this is intentional.
If we can come up with a proper way of conveying this to the user, I'm happy to update the code.
The best way to do it might be to add a tool tip or an (i) icon right next to targen label, explaining this. But, I'm not sure with the other commands, I didn't check it, but the extra arguments should be added during the normal calibration/profiling operation.
That says -d
and -D
, i was trying to use -V
, it didn't get added to the auto-optimize flow.
No I'm not saying that, what I just wanted to point out is that Florian is specifically mentioning "Test Chart Editor" and that he is limiting the options because those are not supported by the editor, meaning that the extra options' whole purpose of existence is to be used with the Test Chart Editor, thus it was intentional...
meaning that the extra options' whole purpose of existence is to be used with the Test Chart Editor, thus it was intentional...
Then why did you say this?
I didn't check it, but the extra arguments should be added during the normal calibration/profiling operation.
Then why did you say this?
I didn't check it, but the extra arguments should be added during the normal calibration/profiling operation.
You are chopping my sentence from the wrong place, I was talking about the extra arguments that are passed to the "other commands":
But, I'm not sure with the other commands, I didn't check it, but the extra arguments should be added during the normal calibration/profiling operation.
I'm not a native English speaker, and clearly you aren't either (hence the name), so let's give a chance to the probability that you might have misunderstood what I've written and try to keep a humble attitude, will you?
I'm going to attempt to try and understand what you meant from the comment that caused the confusion.
This is what caused my confusion, the usage of it
in I didn't check it,
made me believe you were talking about one thing, targen, which made skip over But, I'm not sure with the other commands
before it.
#397 (comment)
The best way to do it might be to add a tool tip or an (i) icon right next to targen label, explaining this. But, I'm not sure with the other commands, I didn't check it, but the extra arguments should be added during the normal calibration/profiling operation.
Plus this at the top of this comment.
#397 (comment)
As I see extra arguments to targen is only passed when you use the Test Chart Editor:
And this at the end.
#397 (comment)
meaning that the extra options' whole purpose of existence is to be used with the Test Chart Editor, thus it was intentional...
Seemed to conflict with the confusing comment at first glance as i didn't read it correctly, i was wrong.
I'm assuming you meant this.
The best way to do it might be to add a tool tip or an (i) icon right next to the targen label explaining it is only for the test chart editor and not apart of the auto-optimize test charts but i'm not sure if the other command arguments apply to calibration/profiling.
If this is what you meant, then yes, the other arguments(at least the top 3 and 5th) apply to all phases.
Kind of yes, that's what I meant, so:
As I see, the extra arguments passed to the targen
command are only used for the Test Chart Editor. But the extra arguments that are passed to the other commands should also be picked up during the calibration and profiling operations and should not be specific to the Test Chart Editor as the executables are not necessarily related to the Test Chart Editor. But, I'm not sure with if the extra arguments are passed to the other commands during the calibration and profiling as I didn't try adding extra arguments to the other commands before doing a calibration and profiling.
That should be clearer 👍