eoyilmaz/displaycal-py3

Forced duplicates removal from a custom sequence of test patches

aproce opened this issue · 2 comments

Test.zip
Describe the feature being requested
When a custom sequence of test patches is run through DisplayCAL, it removes any repeating/duplicate patches from the sequence. I wanted to request for an option (or even forced behavior) which allows retaining the repeating/duplicate patches.

There are cases when I would like to embed repeating patches at fixed interval in a test sequence, so as to monitor the instability in the display color response. Due to forced duplicates removal by DisplayCAL, I am unable to do so.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Profiling' tab
  2. For the Testchart, upload any custom sequence that has repeating/duplicate patches. I have uploaded a test sequence that has a repeating grey patch (stimulus 90.9804 %) after every 20 patches.

Expected behavior
The uploaded custom sequence should remain unmolested, and no repeating patches should be removed. At least an option should be there for this behavior/feature.

As per Testing on versions:

  • OS: Windows 11
  • Python Version: 3.10
  • ArgyllCMS Version: 3.2.0
  • DisplayCAL Version: 3.9.14

It is probably caused by DisplayCAL.worker.insert_ti_patches_omitting_RGB_duplicates() in:

def insert_ti_patches_omitting_RGB_duplicates(cgats1, cgats2_path, logfn=print):
)

Yeah, this is the part of the code that needs to be changed.

Great, you have identified it.