ericcornelissen/pinned-tabs-for-atom

context menu for pinning "projects" and "git" tabs

Closed this issue ยท 3 comments

Not a highly important, but I thought I'd mention it:
I would like to pin things in my right dock (because there are too many tabs, and icons really are enough for that purpose), which works very well apart from the "projects" (which I moved there) and the "git" tab. Both pin well but only via the key combination or via the command directly, but the context menu does not show this option.
I have not figured out why, but after some restarts, these two tabs are not pinned any more. I suspect that they are somewhat different tabs, but I couldn't identify anything in the DOM that would reveal this difference. Maybe you have any thoughts on that? This might be related to #21?

As said, this is not hugely important, just a minor thought.
Many thanks for looking into this anyway. :)

The first issue you describe ("[...] the context menu does not show this option.") is related to #42 & #48. To be fair in this regard I guess the base package can just show the context menu item on all tab. And users can hide it themselves if they so choose in a their own stylesheets ๐Ÿค” I will update this shortly ๐Ÿ‘

The second issue you describe is more worrisome as it probably also applies to other tabs. I cannot tell if #21 is related but it might be. I will try to look into this as well but it will probably take longer, especially given that the steps to reproduce essentially are "it happens sometimes when I restart Atom" (not complaining, it is what it is ๐Ÿ˜„)

The first problem has been resolved with commit c7560e1, after further investigation I've not been able to reproduce or identify a cause for the second problem. I will close this issue for now, if you find a reliable way to reproduce the second problem feel free to reopen this issue. I will publish the fix for the first problem before the end of the year ๐Ÿ‘

Thanks a lot!