/characters/{character_id}/notifications/ - unknown notification type (270)
Closed this issue · 5 comments
Bug
Some notifications returned from /characters/{character_id}/notifications/ are not returning their type, instead they are returning an "unknown notification type (270)" breaking json validation of this response data. Interfering with the normal usage of this endpoint.
likely because they are missing in https://github.com/esi/eve-glue/blob/master/eve_glue/notification_type.py
Request
GET http://characters/character_id/notifications/?datasource=tranquility
Response
Status Code
200
Headers
access-control-allow-credentials: true
access-control-allow-headers: Content-Type,Authorization,If-None-Match,X-User-Agent
access-control-allow-methods: GET,HEAD,OPTIONS
access-control-allow-origin: *
access-control-expose-headers: Content-Type,Warning,ETag,X-Pages,X-ESI-Error-Limit-Remain,X-ESI-Error-Limit-Reset
access-control-max-age: 600
allow: GET,HEAD,OPTIONS
cache-control: private
content-encoding: gzip
content-type: application/json; charset=UTF-8
date: Tue, 21 Nov 2023 13:00:26 GMT
etag: "0c8a255428f1884aa166a3d6070405502874ae160b191eb6be2a326a"
expires: Tue, 21 Nov 2023 13:06:54 GMT
last-modified: Tue, 21 Nov 2023 12:56:54 GMT
strict-transport-security: max-age=31536000
vary: Accept-Encoding
x-esi-error-limit-remain: 100
x-esi-error-limit-reset: 34
x-esi-request-id: 74b9c938-0a99-4484-a16f-e10dc28e1519
Body
Specific ID's can be provided on request, Discord: arielrin
...
{
"notification_id": 1234567890,
"sender_id": 1234567890,
"sender_type": "character",
"text": "corpID: 1234567890\n",
"timestamp": "2023-11-16Txx:yy:00Z",
"type": "unknown notification type (270)"
},
...Expected
200
...
{
"notification_id": 1234567890,
"sender_id": 1234567890,
"sender_type": "character",
"text": "corpID: 1234567890\n",
"timestamp": "2023-11-16T01:22:00Z",
"type": Something valid from https://github.com/esi/eve-glue/blob/master/eve_glue/notification_type.py
},
...Checklist
Check all boxes that apply to this issue:
- Bug description is provided
- Request path is provided
- Response status code is provided
- Response headers are provided
- Response body is provided
- Expected response is provided
PR opened to eve-glue by stroop esi/eve-glue#34
esi/eve-glue#34 has been merged, awaiting swagger spec update and to test
Swagger spec still not updated to include the new enums that have been merged to eve-glue
eve glue has been version bumped, still not in the swagger spec
This december 1st PR has now been reflected in a new v6 notifications endpoint, fixing this issue