esoergel/coderaising

Wiki preview does not render well in the modal.

Closed this issue · 5 comments

When I edit a wiki page, and then click preview, a modal pops up that gives me a responsive version of that page. I can't scroll up or down to see my changes.

@esoergel: Is this the default behavior of django-wiki?

screen shot 2013-06-20 at 8 18 54 pm

Tried this again with all my extensions turned off, and I could indeed scroll. Still don't like the pop-up preview, though. I did function properly, though.

Hmm, the preview doesn't work for me at all, actually. I pretty much just dropped in django-wiki and changed - ooooooh, I see. I changed the base.html file some to preserve the site-wide navbar. I wonder if I broke it then. I agree with you though, a modal is a little much, ideally I'd like an in-page preview. What do you think, should we just remove the button for now? I'll try it out locally and see if I can figure out what's happening.

Ooops, didn't mean to close this

On Fri, Jun 21, 2013 at 4:44 PM, Ethan Soergel notifications@github.comwrote:

Hmm, the preview doesn't work for me at all, actually. I pretty much just
dropped in django-wiki and changed - ooooooh, I see. I changed the
base.html file some to preserve the site-wide navbar. I wonder if I broke
it then.

Is the site-wide navbar an {% include %}, or part of base.html?

I agree with you though, a modal is a little much, ideally I'd like an
in-page preview. What do you think, should we just remove the button for
now?

Save-->re-edit-->save--re-edit isn't much different than
save-->preview-->re-edit-->save, right?

I'll try it out locally and see if I can figure out what's happening.


Reply to this email directly or view it on GitHubhttps://github.com//issues/24#issuecomment-19839643
.

I just removed the preview button. A lot of the other wiki functionality is broken for me as well, though. I'll have to sort through that later