ethereum/ethereumj

unused line of code?

kant111 opened this issue · 2 comments

I was trying to see if Block Miner runs an independent separate thread with a time period or is there something that triggers a mining? Meanwhile, I found the code below where I think it is unused unless there is some spring framework magic that I am unaware of?

https://github.com/ethereum/ethereumj/blob/develop/ethereumj-core/src/main/java/org/ethereum/mine/BlockMiner.java#L53

Yep, as far as I can see this executor is not used in any part of the codebase.

@mkalinin should I just remove this line and send a PR? Also can you please point where the independent thread for mining gets created? Thanks.