ethz-asl/3dsnet

Possible typo in adaptive norm

qiminchen opened this issue · 2 comments

Line 351/354 and line 359/362 should be norm2 and norm3?

3dsnet/model/meshflow.py

Lines 338 to 362 in e823742

sph = self.norm0(sph, content_latent_vector, adain_params[:, 0:3 * 2])
# First Deform Block computation and its instance norm
pred_y1, _ = self.db1(content_latent_vector, sph, None, time)
if self.adaptive:
pred_y1 = self.norm1(pred_y1, content_latent_vector,
adain_params[:, 3 * 2:3 * 4])
else:
pred_y1 = self.norm1(pred_y1, content_latent_vector)
# Second Deform Block computation and its instance norm
pred_y2, _ = self.db2(content_latent_vector, pred_y1, None, time)
if self.adaptive:
pred_y2 = self.norm1(pred_y2, content_latent_vector,
adain_params[:, 3 * 4:3 * 6])
else:
pred_y2 = self.norm1(pred_y2, content_latent_vector)
# Third Deform Block computation and its instance norm
pred_y3, _ = self.db3(content_latent_vector, pred_y2, None, time)
if self.adaptive:
pred_y3 = self.norm1(pred_y3, content_latent_vector,
adain_params[:, 3 * 6:3 * 8])
else:
pred_y3 = self.norm1(pred_y3, content_latent_vector)

I think it's a typo too. the layer norm2 norm3 are not utilized in the forword

Hi @qiminchen and @csjxchen, sorry for not replying before! This definitely is a typo :)

If you are working on it, you could simply make a PR to fix it and adjust ckpt weights. I will look into it as soon as I find time.