eugene-manuilov/typeorm-uml

Plantuml server does not support https

raphael-leger opened this issue · 2 comments

raphael-leger commented

Hi again,

The default plantuml url should probably be http://www.plantuml.com/plantuml (http, not https)

typeorm-uml/src/builder/typeorm-uml.class.ts

Line 95 in cf123d5

const plantumlUrl = flags['plantuml-url'] || 'https://www.plantuml.com/plantuml';

With the current default, executing new TypeormUml().build(...) produces the following error:

(node:12798) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_PROTOCOL]: Protocol "https:" not supported. Expected "http:"
    at new ClientRequest (_http_client.js:155:11)
    at request (http.js:50:10)
    at Object.get (http.js:54:15)
    at /myproject/node_modules/typeorm-uml/lib/builder/typeorm-uml.class.js:63:20

To be noted that when accessing http://www.plantuml.com/plantuml or https://www.plantuml.com/plantuml in a browser (chrome at least), it shows up 'Not Secure' in the status bar.

eugene-manuilov commented

Thanks, @raphael-leger! Updated and published as @next for now.

eugene-manuilov commented

Ok, it has been shipped with the new version 1.6.0. Closing this ticket.

  • 👍1