fabiogiglietto/CooRnet

get_coord_share issue

Closed this issue · 3 comments

There is a small bug in the get_coord_share function (or rather in the utils in the build_coord_graph function). For some values of coordination_interval it does not work properly. I think it's better to stop the function if it cannot be executed, specifying the error by usign the "stop" function

Error in if (E(highly_connected_h)[e_h]$t_coord_share != 0 { : l'argomento ha lunghezza zero Called from: build_coord_graph(ct_shares.df, coordinated_shares, percentile_edge_weight)

Seems to happen with a specific dataset only but it is worth to investigate the causes.

The problem was solved by changing the argument of the if statement

We need to better understand why E(highly_connected_h)[e_h]$t_coord_share has length 0 and do more tests to ensure that the output in terms of coordinated entities and networks is not affected by this part of code.