facebook/fbjs

Upgrade node-fetch to >= 2.3.0 to fix semantic-release users that use styled-components

kopax opened this issue · 1 comments

kopax commented

Environment

We are experiencing issue on travis while using semantic-release.

This happen because of a package having being fixed node-fetch@2.3.0 for semantic-release to work and styled-components having an outdated node-fetch through isomorphic-fetch.

Users that use both semantic-release and styled-components will have issues.

Related issues:

Reproduction

https://travis-ci.org/yeutech-lab/rollup-umd-documentation/jobs/459847412

$ npm ls node-fetch
@yeutech-lab/rollup-umd-documentation@2.4.2 /home/dka/workspace/github.com/yeutech-lab/rollup-umd-documentation
├─┬ @semantic-release/github@5.2.5
│ └─┬ @octokit/rest@16.0.1
│   └── node-fetch@2.3.0 
└─┬ styled-components@4.1.1
  └─┬ css-to-react-native@2.2.2
    └─┬ fbjs@0.8.17
      └─┬ isomorphic-fetch@2.2.1
        └── node-fetch@1.7.3 

Steps to reproduce

  • semantic-release: v15.12.1
  • styled-components: v4.1.1

Expected Behavior

To have node-fetch@2.3.0

Actual Behavior

Styled-components bring node-fetch@1.7.3 and breaks semantic-release.

Solution

zpao commented

We're not going to do anything here. css-to-react-native shouldn't have been using fbjs (or rather, it was at their own risk - we make this very clear in our readme). Looks like you fixed it in styled-components/css-to-react-native#99 - should probably get that shipped.